From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A12CC433EF for ; Mon, 13 Jun 2022 09:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240814AbiFMJZT (ORCPT ); Mon, 13 Jun 2022 05:25:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiFMJZS (ORCPT ); Mon, 13 Jun 2022 05:25:18 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6BEB12AC1; Mon, 13 Jun 2022 02:25:17 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id a29so7885267lfk.2; Mon, 13 Jun 2022 02:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xUYF6Y1hCqd5t8WxA/+uJZZHaISwa+qUcLkVEX3FDtY=; b=OZRK4j4GfMvvujegmLuiiyQfatSbywM4kRdRc1tMAOzluF9+R3ROjAPU3l7ABr8vnN jYtnDvoHI2bSR7Kn4LK8/ztorjpVQXZ2uSDdgpxBZhlEi2T9raelsgwGWpgrCmVTF1ng +jtfpdHxAxBWbneZjvuPphDXeVMYqaI7GuHnfR/C9zsLfnkFjud27cobWdzB8VQCmmf7 CUqYCzZDZac86aaP53eZzM6opXQBwDLw0lkE/+JhAnd0rjVfdtJLXqWYI/7dX/nxVL7B 6oAE7Xd3AmopNE8kT4f8CY9HGoy/EEkLZuu4y4iGct6vRqeb8A+Agl+ljt2/6CRdvDGF W5cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xUYF6Y1hCqd5t8WxA/+uJZZHaISwa+qUcLkVEX3FDtY=; b=jCfGaR9EhmtmrGq19XLLS2LQymZPC9QkkvQwyzmTmszJ7aOvm04dsmUt/lYG2dpHDF ACoqEZmr34IDvsexmDrvLt0IFTmKU12aCkskwF7w+ab1Tp2ABAhF3jmT21vcMZad66zu BTKtg6PKcpm7U2jX/u9m1zl2MZ0EC+p3WdQvwn6HgnVEqazrn4kyse0+3CJfuw94cuFn 94bJtCYyimjNhfNtGDYUDiuhEGUibgSxFcIs6LymLtXtDDVb7r4lBTxJ867tku+5kSyP h42E43hHXfoARWdpi8kDfRBMDnwYIrcMew6qqJX/yCMkEn0QBOOVINKkpY7XSbAmrL2l u7Sw== X-Gm-Message-State: AOAM532FpcBbl+Rs6UmKKv1kfIhbruI1OqPMEM0+kMEePEU1icOV70wl PgJC71w7jNMWxE+p2oim2X8pNgGCRzJ113vZx0o= X-Google-Smtp-Source: ABdhPJxXc679feoHAf2D/GisUYLrlv1MVhsVhMMqlkvsfBNlHHdqjK5/eafARXLQjX3HPF+NV1BKVh2veyAWJgShjls= X-Received: by 2002:a05:6512:1052:b0:479:1f92:13b4 with SMTP id c18-20020a056512105200b004791f9213b4mr27864941lfb.200.1655112316061; Mon, 13 Jun 2022 02:25:16 -0700 (PDT) MIME-Version: 1.0 References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-13-tmaimon77@gmail.com> <381ff739-e898-8812-d549-df7101f0eaa2@linaro.org> In-Reply-To: <381ff739-e898-8812-d549-df7101f0eaa2@linaro.org> From: Tomer Maimon Date: Mon, 13 Jun 2022 12:25:05 +0300 Message-ID: Subject: Re: [PATCH v2 12/20] dt-bindings: reset: npcm: Add support for NPCM8XX To: Krzysztof Kozlowski Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hi Krzysztof, Thanks for your clarification. We can remove the dt-binding file and use numbers in the DTS, appreciate if you can answer few additional questions: 1. Do you suggest adding all NPCM reset values to the NPCM reset document or the reset values should describe in the module documentation that uses it? 2. Some of the NPCM7XX document modules describe the reset value they use from the dt-binding for example: https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/iio/adc/nuvoton%2Cnpcm750-adc.yaml#L61 If we remove the NPCM8XX dt-binding file should we describe the NPCM8XX values in the NPCM-ADC document file? Best regards, Tomer On Fri, 10 Jun 2022 at 12:55, Krzysztof Kozlowski wrote: > > On 10/06/2022 00:05, Tomer Maimon wrote: > > Hi Krzysztof, > > > > Sorry, but I thought the fix is only to add an explanation to the > > dt-binding file as was done in V2. > > > > The NPCM8XX binding is done in the same way as the NPCM7XX and both > > use the same reset driver and use the same reset method in upstreamed > > NPCM reset driver. > > > > Can you please explain again what you suggest to do? > > If you want abstract IDs, they must be abstract, so not representing > hardware registers. Then they start at 1 and are incremented by 1. > > Other option is to skip such IDs entirely and use register > offsets/addresses directly, like Arnd suggested in linked documents. I > think he expressed it clearly, so please read his answers which I linked > in previous discussion. > > There is no single reason to store register addresses/values/offsets as > binding headers. These are not bindings. > > Best regards, > Krzysztof