From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A8EC433F5 for ; Sun, 28 Nov 2021 19:20:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356920AbhK1TYO (ORCPT ); Sun, 28 Nov 2021 14:24:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239974AbhK1TWN (ORCPT ); Sun, 28 Nov 2021 14:22:13 -0500 Received: from mail-ua1-x936.google.com (mail-ua1-x936.google.com [IPv6:2607:f8b0:4864:20::936]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 319DFC061748 for ; Sun, 28 Nov 2021 11:18:57 -0800 (PST) Received: by mail-ua1-x936.google.com with SMTP id l24so29554023uak.2 for ; Sun, 28 Nov 2021 11:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qo3PAgy4ecMdw6oNTVpGy0tUmuQCrp/Wiq4eob/mtQI=; b=JrnKf03DFARe/5OgV32WW8Df/++5lQu9a9KwwebrG4F3cENZIR24UM+EnG3UB7JRZs AYtQYtIyGfeXW5sFxNHDLgotN4qeHXWnDApj0AXxdq6X8gSsfhuufDanYFUIF8ISRua0 FYengmxYft6soxUVVXF8fdn3fWiB5nyGslBxUaiM5yAoVsVMpph2biWElyMT60LaN7dS Bgl2HkXSjsH7JW2nac2DxJq/87RD5IpUGitYqZNbb30LA7OQbDmhgrTww84ahRk7pv5D /sBrnbWINjMtiUxcK7z7aLBf5ZgehQPpvxd2Vj+xL9OlPxHgpMmcQxA5qm248c+oezWv 0uGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qo3PAgy4ecMdw6oNTVpGy0tUmuQCrp/Wiq4eob/mtQI=; b=JbUIerpW7i09WKx/3459OorPPjQStVz7xrgf/AvaAyPKtYk3XWrp7FDqgSZ6QYETf6 Uv4ukzRVTXZXdI9VgAkKm4dgV0ypluaQnOFq5pIXKGP+KIvgN6IDFob6tao+9vkXWdRf 1Mpd+KMoTwRoq0zt5Z3lKRtJF86SU8cxWe7AS3Mw61Argjx2XFTybYwQuJNETgcJ2u7q mQE+jK9CO0uhwZ5s7TyMOdENcO77Eewr4mriZIq3449yFUYL35a9Kx88tMtluBEqPA3O VF+RaX9a3vUfUCxZOelAli5nLEMDkPnXjc410RpKFCKYo4j0XSFSA4crMgsiaUcyPgdd o/Bw== X-Gm-Message-State: AOAM531CYVKTQZwZ1Bd8n0Oa/wUSwoFv87gRBLRTObZZFuvfviu89YAF Z9/cRy+wITfrWnc2spjsT8kdTt8zkzzd0uJMeo10Lw== X-Google-Smtp-Source: ABdhPJwCaOpHAYtsRrert9di7ZEA+CQ02tXeFDu0XfEynvpdrOa/GFa85qKmLDApqL7maqiBFayRDSykbj0HkujqoXQ= X-Received: by 2002:a05:6102:f10:: with SMTP id v16mr29145367vss.86.1638127136273; Sun, 28 Nov 2021 11:18:56 -0800 (PST) MIME-Version: 1.0 References: <20211121165647.26706-1-semen.protsenko@linaro.org> <20211121165647.26706-10-semen.protsenko@linaro.org> <20211123160623.GB2326185@roeck-us.net> <037e8534-746d-da0a-24da-a47a9856d689@roeck-us.net> In-Reply-To: <037e8534-746d-da0a-24da-a47a9856d689@roeck-us.net> From: Sam Protsenko Date: Sun, 28 Nov 2021 21:18:45 +0200 Message-ID: Subject: Re: [PATCH v4 09/12] watchdog: s3c2410: Cleanup PMU related code To: Guenter Roeck Cc: Wim Van Sebroeck , Rob Herring , Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Sun, 28 Nov 2021 at 19:56, Guenter Roeck wrote: > > On 11/27/21 2:52 PM, Sam Protsenko wrote: > > On Wed, 24 Nov 2021 at 01:30, Sam Protsenko wrote: > >> > >> On Wed, 24 Nov 2021 at 00:33, Guenter Roeck wrote: > >>> > >>> On 11/23/21 8:17 AM, Sam Protsenko wrote: > >>>> On Tue, 23 Nov 2021 at 18:06, Guenter Roeck wrote: > >>>>> > >>>>> On Sun, Nov 21, 2021 at 06:56:44PM +0200, Sam Protsenko wrote: > >>>>>> Now that PMU enablement code was extended for new Exynos SoCs, it > >>>>>> doesn't look very cohesive and consistent anymore. Do a bit of renaming, > >>>>>> grouping and style changes, to make it look good again. While at it, add > >>>>>> quirks documentation as well. > >>>>>> > >>>>>> No functional change, just a refactoring commit. > >>>>>> > >>>>>> Signed-off-by: Sam Protsenko > >>>>>> Reviewed-by: Krzysztof Kozlowski > >>>>>> Reviewed-by: Guenter Roeck > >>>>>> --- > >>>>>> Changes in v4: > >>>>>> - Added R-b tag by Guenter Roeck > >>>>>> > >>>>>> Changes in v3: > >>>>>> - Added quirks documentation > >>>>>> - Added R-b tag by Krzysztof Kozlowski > >>>>>> > >>>>>> Changes in v2: > >>>>>> - (none): it's a new patch > >>>>>> > >>>>>> drivers/watchdog/s3c2410_wdt.c | 83 ++++++++++++++++++++++++---------- > >>>>>> 1 file changed, 58 insertions(+), 25 deletions(-) > >>>>>> > >>>>>> diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > >>>>>> index ec341c876225..f211be8bf976 100644 > >>>>>> --- a/drivers/watchdog/s3c2410_wdt.c > >>>>>> +++ b/drivers/watchdog/s3c2410_wdt.c > >>>>>> @@ -56,17 +56,51 @@ > >>>>>> #define EXYNOS5_RST_STAT_REG_OFFSET 0x0404 > >>>>>> #define EXYNOS5_WDT_DISABLE_REG_OFFSET 0x0408 > >>>>>> #define EXYNOS5_WDT_MASK_RESET_REG_OFFSET 0x040c > >>>>>> -#define QUIRK_HAS_PMU_CONFIG (1 << 0) > >>>>>> -#define QUIRK_HAS_RST_STAT (1 << 1) > >>>>>> -#define QUIRK_HAS_WTCLRINT_REG (1 << 2) > >>>>>> + > >>>>>> +/** > >>>>> > >>>>> 0-day complains: > >>>>> > >>>>> drivers/watchdog/s3c2410_wdt.c:94: warning: expecting prototype for Quirk flags for different Samsung watchdog IP(). Prototype was for QUIRK_HAS_WTCLRINT_REG() instead > >>>>> > >>>>> It doesn't seem to like the idea of documented bit masks. Not really sure > >>>>> what to do here. I am inclined to ignore it, but I don't want to get flooded > >>>>> by 0-day complaints until I retire either. Any idea ? > >>>>> > >>>> > >>>> Seems like 0-day thinks this kernel-doc comment is for the first > >>>> define only, and thus the comment has wrong format, or something like > >>>> that. I tried to follow the same style as GFP_KERNEL and others are > >>>> documented. > >>>> > >>>> Anyway, if you don't like 0-day complaints, can you please just > >>>> replace kernel-doc comment (/**) with regular comment (/*), by > >>>> removing one asterisk in the patch? Or I can re-send the patch > >>>> correspondingly -- then just let me know. > >>>> > >>> > >>> Oh, never mind. Let's just hope that 0-day stops complaining at some point. > >>> > >> > >> Just sent v5 for this patch, fixing that 0-day warning properly. Found > >> info about it here: [1]. So to check that warning, apparently it's > >> enough to run "make W=n" build, or dry-run for kernel-doc script like > >> this: > >> > >> $ scripts/kernel-doc -v -none drivers/watchdog/s3c2410_wdt.c > >> > >> Anyway, please take v4 series + v5 for this patch. Hope that'll be all > >> for 0-day swearing :) > >> > >> [1] https://github.com/torvalds/linux/blob/master/Documentation/doc-guide/kernel-doc.rst > >> > > > > Hi Guenter, > > > > Can you please take this patch: > > > > [PATCH v4 12/12] watchdog: s3c2410: Add Exynos850 support > > > > and replace "Cleanup PMU related code" patch you already applied with this one: > > > > [PATCH v5] watchdog: s3c2410: Cleanup PMU related code > > > > I can see you already took most of WDT patches I sent, but those two > > seem to be missing. > > > > Upstream work is always "time permitting". Done now. > Thank you, Guenter! > > Also, I can't see my patches (which are already present in your > > "watchdog-next" branch) in linux-next/master. Is that expected, or I'm > > missing something? > > > My watchdog-next branch is for 0-day coverage only. It is not made > available in linux-next. linux-next pulls watchdog related changes > from the official watchdog repository at > git://www.linux-watchdog.org/linux-watchdog-next.git#master > > Guenter