* [PATCH] watchdog: renesas_wdt: Fix typos
@ 2018-11-02 19:21 Fabrizio Castro
2018-11-02 19:48 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Fabrizio Castro @ 2018-11-02 19:21 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck
Cc: Fabrizio Castro, linux-watchdog, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/watchdog/renesas_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 0d74c3e..b570962 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
goto out_pm_disable;
}
- priv->wdev.info = &rwdt_ident,
- priv->wdev.ops = &rwdt_ops,
+ priv->wdev.info = &rwdt_ident;
+ priv->wdev.ops = &rwdt_ops;
priv->wdev.parent = &pdev->dev;
priv->wdev.min_timeout = 1;
priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: renesas_wdt: Fix typos
2018-11-02 19:21 [PATCH] watchdog: renesas_wdt: Fix typos Fabrizio Castro
@ 2018-11-02 19:48 ` Guenter Roeck
2018-11-05 9:52 ` Geert Uytterhoeven
2018-11-05 10:43 ` Fabrizio Castro
0 siblings, 2 replies; 4+ messages in thread
From: Guenter Roeck @ 2018-11-02 19:48 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Wim Van Sebroeck, linux-watchdog, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc
On Fri, Nov 02, 2018 at 07:21:11PM +0000, Fabrizio Castro wrote:
Do not use "," but ";" to separate instructions.
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/renesas_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 0d74c3e..b570962 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
> goto out_pm_disable;
> }
>
> - priv->wdev.info = &rwdt_ident,
> - priv->wdev.ops = &rwdt_ops,
> + priv->wdev.info = &rwdt_ident;
> + priv->wdev.ops = &rwdt_ops;
> priv->wdev.parent = &pdev->dev;
> priv->wdev.min_timeout = 1;
> priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: renesas_wdt: Fix typos
2018-11-02 19:48 ` Guenter Roeck
@ 2018-11-05 9:52 ` Geert Uytterhoeven
2018-11-05 10:43 ` Fabrizio Castro
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-11-05 9:52 UTC (permalink / raw)
To: Guenter Roeck
Cc: Fabrizio Castro, Wim Van Sebroeck, Linux Watchdog Mailing List,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
Linux-Renesas
On Fri, Nov 2, 2018 at 8:48 PM Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Nov 02, 2018 at 07:21:11PM +0000, Fabrizio Castro wrote:
>
> Do not use "," but ";" to separate instructions.
+1
Thanks, my eyes had a hard time finding out what had been changed ;-)
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> > ---
> > drivers/watchdog/renesas_wdt.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> > index 0d74c3e..b570962 100644
> > --- a/drivers/watchdog/renesas_wdt.c
> > +++ b/drivers/watchdog/renesas_wdt.c
> > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
> > goto out_pm_disable;
> > }
> >
> > - priv->wdev.info = &rwdt_ident,
> > - priv->wdev.ops = &rwdt_ops,
> > + priv->wdev.info = &rwdt_ident;
> > + priv->wdev.ops = &rwdt_ops;
> > priv->wdev.parent = &pdev->dev;
> > priv->wdev.min_timeout = 1;
> > priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] watchdog: renesas_wdt: Fix typos
2018-11-02 19:48 ` Guenter Roeck
2018-11-05 9:52 ` Geert Uytterhoeven
@ 2018-11-05 10:43 ` Fabrizio Castro
1 sibling, 0 replies; 4+ messages in thread
From: Fabrizio Castro @ 2018-11-05 10:43 UTC (permalink / raw)
To: Guenter Roeck
Cc: Wim Van Sebroeck, linux-watchdog, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc
> Subject: Re: [PATCH] watchdog: renesas_wdt: Fix typos
>
> On Fri, Nov 02, 2018 at 07:21:11PM +0000, Fabrizio Castro wrote:
>
> Do not use "," but ";" to separate instructions.
I agree, will send a v2 for this.
Thanks,
Fab
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> > ---
> > drivers/watchdog/renesas_wdt.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> > index 0d74c3e..b570962 100644
> > --- a/drivers/watchdog/renesas_wdt.c
> > +++ b/drivers/watchdog/renesas_wdt.c
> > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
> > goto out_pm_disable;
> > }
> >
> > -priv->wdev.info = &rwdt_ident,
> > -priv->wdev.ops = &rwdt_ops,
> > +priv->wdev.info = &rwdt_ident;
> > +priv->wdev.ops = &rwdt_ops;
> > priv->wdev.parent = &pdev->dev;
> > priv->wdev.min_timeout = 1;
> > priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
> > --
> > 2.7.4
> >
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-05 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02 19:21 [PATCH] watchdog: renesas_wdt: Fix typos Fabrizio Castro
2018-11-02 19:48 ` Guenter Roeck
2018-11-05 9:52 ` Geert Uytterhoeven
2018-11-05 10:43 ` Fabrizio Castro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).