From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"sre@kernel.org" <sre@kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"wens@csie.org" <wens@csie.org>,
"saravanak@google.com" <saravanak@google.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"jroedel@suse.de" <jroedel@suse.de>,
"rafael@kernel.org" <rafael@kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"agross@kernel.org" <agross@kernel.org>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>
Subject: Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init
Date: Mon, 15 Feb 2021 12:31:22 +0100 [thread overview]
Message-ID: <YCpbit8W3xsvb37Q@kroah.com> (raw)
In-Reply-To: <400d3e82-a76e-136c-0e03-ed7e40608e2a@redhat.com>
On Mon, Feb 15, 2021 at 11:37:26AM +0100, Hans de Goede wrote:
> Hi,
>
> On 2/15/21 8:22 AM, Vaittinen, Matti wrote:
> >
> > On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 2/13/21 4:27 PM, Guenter Roeck wrote:
> >>> On 2/13/21 7:03 AM, Hans de Goede wrote:
> >>> [ ... ]
> >>>> I think something like this should work:
> >>>>
> >>>> static int devm_delayed_work_autocancel(struct device *dev,
> >>>> struct delayed_work *w,
> >>>> void (*worker)(struct
> >>>> work_struct *work)) {
> >>>> INIT_DELAYED_WORK(w, worker);
> >>>> return devm_add_action(dev, (void (*action)(void
> >>>> *))cancel_delayed_work_sync, w);
> >>>> }
> >>>>
> >>>> I'm not sure about the cast, that may need something like this
> >>>> instead:
> >>>>
> >>>> typedef void (*devm_action_func)(void *);
> >>>>
> >>>> static int devm_delayed_work_autocancel(struct device *dev,
> >>>> struct delayed_work *w,
> >>>> void (*worker)(struct
> >>>> work_struct *work)) {
> >>>> INIT_DELAYED_WORK(w, worker);
> >>>> return devm_add_action(dev,
> >>>> (devm_action_func)cancel_delayed_work_sync, w);
> >>>
> >>> Unfortunately, you can not type cast function pointers in C. It is
> >>> against the C ABI.
> >>> I am sure it is done in a few places in the kernel anyway, but
> >>> those are wrong.
> >>
> >> I see, bummer.
> >
> > I think using devm_add_action() is still a good idea.
>
> Yes, we could also just have a 1 line static inline function to do
> the function-cast. Like this:
>
> static inline void devm_delayed_work_autocancel_func(void *work)
> {
> cancel_delayed_work_sync(work);
> }
>
> static inline int devm_delayed_work_autocancel(struct device *dev, struct delayed_work *w, void (*worker)(struct work_struct *work))
> {
> INIT_DELAYED_WORK(w, worker);
> return devm_add_action(dev, devm_delayed_work_autocancel_func, w);
> }
>
> Both functions will then simply be compiled out in files which do not
> use them.
>
> >> If we add a devm_clk_prepare_enable() helper that should probably be
> >> added
> >> to drivers/clk/clk-devres.c and not to drivers/base/devres.c .
> >>
> >> I also still wonder if we cannot find a better place for this new
> >> devm_delayed_work_autocancel() helper but nothing comes to mind.
> >
> > I don't like the idea of including device.h from workqueue.h - and I
> > think this would be necessary if we added
> > devm_delayed_work_autocancel() as inline in workqueue.h, right?
>
> Yes.
>
> > I also see strong objection towards the devm managed clean-ups.
>
> Yes it seems that there are some people who don't like this, where as
> others do like them.
>
> > How about adding some devm-helpers.c in drivers/base - where we could
> > collect devm-based helpers - and which could be enabled by own CONFIG -
> > and left out by those who dislike it?
>
> I would make this something configurable through Kconfig, but if
> go the static inline route, which I'm in favor of then we could just
> have a:
>
> include/linux/devm-cleanup-helpers.h
>
> And put everything (including kdoc texts) there.
>
> This way the functionality is 100% opt-in (by explicitly including
> the header if you want the helpers) which hopefully makes this a
> bit more acceptable to people who don't like this style of cleanups.
>
> I would be even happy to act as the upstream maintainer for such a
> include/linux/devm-cleanup-helpers.h file, I can maintain it as part
> of the platform-drivers-x86 tree (with its own MAINTAINERS entry).
>
> Greg, would this be an acceptable solution to you ?
I don't know, sorry, let's revisit this after 5.12-rc1 is out, with a
patch set that I can review again, and we can go from there as I can't
do anything until then...
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-15 11:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 11:58 [RFC PATCH 0/7] Add managed version of delayed work init Matti Vaittinen
2021-02-13 11:58 ` [RFC PATCH 1/7] drivers: base: Add resource " Matti Vaittinen
2021-02-13 12:16 ` Greg Kroah-Hartman
2021-02-13 12:26 ` Vaittinen, Matti
2021-02-13 12:38 ` gregkh
2021-02-13 13:18 ` Hans de Goede
2021-02-13 13:33 ` Greg Kroah-Hartman
2021-02-13 14:38 ` Hans de Goede
2021-02-13 14:52 ` Hans de Goede
2021-02-15 6:58 ` Matti Vaittinen
2021-02-13 15:03 ` Hans de Goede
2021-02-13 15:27 ` Guenter Roeck
2021-02-13 15:59 ` Hans de Goede
2021-02-13 18:17 ` Guenter Roeck
2021-02-15 7:22 ` Vaittinen, Matti
2021-02-15 10:37 ` Hans de Goede
2021-02-15 11:31 ` gregkh [this message]
2021-02-15 11:43 ` Hans de Goede
2021-02-15 13:12 ` Vaittinen, Matti
2021-02-13 12:18 ` [RFC PATCH 7/7] watchdog: retu_wdt: Clean-up by using managed " Matti Vaittinen
2021-02-18 16:28 ` [RFC PATCH 0/7] Add managed version of delayed " mark gross
2021-02-19 10:35 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCpbit8W3xsvb37Q@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jroedel@suse.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mgross@linux.intel.com \
--cc=myungjoo.ham@samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).