From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67734C74A5B for ; Sat, 11 Mar 2023 15:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbjCKPGM (ORCPT ); Sat, 11 Mar 2023 10:06:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229772AbjCKPGL (ORCPT ); Sat, 11 Mar 2023 10:06:11 -0500 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5778011E6CF for ; Sat, 11 Mar 2023 07:06:09 -0800 (PST) Received: by mail-oo1-xc34.google.com with SMTP id c184-20020a4a4fc1000000b005250b2dc0easo1235089oob.2 for ; Sat, 11 Mar 2023 07:06:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678547168; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QSjJSFKnSJ9NNZL9oVyJv4eP2OOu2hx/+ygM+UpA2Gk=; b=R5gi8dNiXcO8VhEzWnGZ+j1QDnktS/fNhHnRz5EIzqAsQko/NXeD4amguP6U5pRbxT YaU8ljLavK2ZKjct/VC7ZlN25yDbjQgGe5z7dkIq0kLgClkbAmYGhS8NgFEl2vPg34gx ux8BPoH5tDkhwGPVFHk1ZXql3lXwxXtJEcvLfXmW/cFI1sOcWyNksw7992x7Y85bLAC9 w19g0q9RR54pHTdoaizS3hbet8DLhnbgeQT07H9c41LKRveLqVo93h1A93WbpIoJOUPq 9bMDZktPQ4y6Umct1tGpd6Hed7X6DeCsknMu+iAogSMkPzwTJ/megjUy/aHcK5TTJUjm hgYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678547168; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QSjJSFKnSJ9NNZL9oVyJv4eP2OOu2hx/+ygM+UpA2Gk=; b=IH78+OM6zRT5MTXNIA1Wb8VyhPWZYGIzZEDLvx/CKoGwj49sbS5Vco5vpfcFQpEU+j BiUiEK/7uhCZuUSgySPDvb82AD/VG7zcXsurSzZw6si3daopjmXYVA33STlgNwtFXaLR FLfufIDA2Ue934Vq+JBF289DuwZp9sz+bLRdz7v0dPw8xwkQFlmBxEKFxV7SLMCBZCQW lhvz3Q1B0Q4+LEOGGTxfkOzWiYeXbRVhYjyb1oe3tb//GSmgQfPAas+R+pQXB8sMny/8 f2N2HjD7WuYcz6t0a2ajGKzXERcA9sm2ddfAUxO6odJvn2/r1QCXvfUypL9DMKvSqweI sRLA== X-Gm-Message-State: AO0yUKVr6wZXY8n6pNqv7T1EJ0/xwpA8DyZwrsmTuTCpH4wuf78xTM92 8YlP0jbEnex9JW8JFZ1LpPwtAw== X-Google-Smtp-Source: AK7set8wgUqiaZeZ2snB6JPbJ/8K6anS+l6yd/zrihTWdRMWzgZwMR96bH6fkwKpnWCc1kTMEiavnw== X-Received: by 2002:a4a:c183:0:b0:51f:fa7e:3804 with SMTP id w3-20020a4ac183000000b0051ffa7e3804mr12287503oop.8.1678547168626; Sat, 11 Mar 2023 07:06:08 -0800 (PST) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id x67-20020a4a4146000000b00525240c6149sm1092732ooa.31.2023.03.11.07.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Mar 2023 07:06:07 -0800 (PST) Date: Sat, 11 Mar 2023 10:06:05 -0500 From: William Breathitt Gray To: Guenter Roeck Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Paul Demetrotion , techsupport@winsystems.com Subject: Re: [PATCH] watchdog: ebc-c384_wdt: Migrate to the regmap API Message-ID: References: <20230311004404.62980-1-william.gray@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b+Kv2GvGpypcTEIM" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org --b+Kv2GvGpypcTEIM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 11, 2023 at 06:04:08AM -0800, Guenter Roeck wrote: > On Fri, Mar 10, 2023 at 07:44:04PM -0500, William Breathitt Gray wrote: > > The regmap API supports IO port accessors so we can take advantage of > > regmap abstractions rather than handling access to the device registers > > directly in the driver. > >=20 > > Suggested-by: Andy Shevchenko > > Signed-off-by: William Breathitt Gray >=20 > I assume you did, but just to be sure: Did you test this on hardware ? I've only done a build test; I no longer have access to a WINSYSTEMS EBC-C384 motherboard to test this on real hardware. I've CC'd Paul Demetrotion and the WINSYSTEMS tech support list to this thread as hopefully one of the WINSYSTEMS engineers may help us test this. > > @@ -37,43 +40,54 @@ module_param(timeout, uint, 0); > > MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds (default=3D" > > __MODULE_STRING(WATCHDOG_TIMEOUT) ")"); > > =20 > > +static const struct regmap_range ebc_c384_wdt_wr_ranges[] =3D { > > + regmap_reg_range(0x1, 0x2), >=20 > Any reasons for not using defines ? I feel direct addresses are somewhat clearer in this context. Regmap configurations describe the address range of valid read and write operations. Although the range for this device is simple, other devices might have multiple ranges with gaps of invalid addresses. For example, our valid write address range is 0x1-0x2 here: regmap_reg_range(0x1, 0x2) Which is much clearer than trying to match these to register defines: regmap_reg_range(CFG_REG, PET_REG) Because it's not immediately clear that CFG_REG to PET_REG is a contiguous address range. > > +}; > > +static const struct regmap_access_table ebc_c384_wdt_wr_table =3D { > > + .yes_ranges =3D ebc_c384_wdt_wr_ranges, > > + .n_yes_ranges =3D ARRAY_SIZE(ebc_c384_wdt_wr_ranges), > > +}; > > +static const struct regmap_config ebc_c384_wdt_regmap_config =3D { > > + .reg_bits =3D 8, > > + .reg_stride =3D 1, > > + .val_bits =3D 8, > > + .io_port =3D true, > > + .max_register =3D 0x2, >=20 > Any reason for not using a define ? Same reason as above: `max_register =3D 0x2` is already clear enough and `max_register =3D EBC_C384_MAX_REGISTER` wouldn't add any substantial clarity. > > + .wr_table =3D &ebc_c384_wdt_wr_table, > > +}; > > + > > static int ebc_c384_wdt_start(struct watchdog_device *wdev) > > { > > + struct regmap *const map =3D wdev->driver_data; >=20 > Please use watchdog_get_drvdata() and watchdog_set_drvdata() when accessi= ng > or setting watchdog driver data. >=20 > Guenter I'll adjust the driver_data interactions in my v2 submission to utilize watchdog_get_drvdata() and watchdog_set_drvdata(). William Breathitt Gray --b+Kv2GvGpypcTEIM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZAyY3QAKCRC1SFbKvhIj K7ZYAP0ame//zn/G+yvSJeRUMTvZqJhg5hNgtPG5kKZDam+8mgEA2zNrGImNqwNe bjBGtRFEADurS58TbPdwdjn8yZ+9QAE= =zCZs -----END PGP SIGNATURE----- --b+Kv2GvGpypcTEIM--