From: Benjamin GAIGNARD <benjamin.gaignard@st.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Alexandre TORGUE <alexandre.torgue@st.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: watchdog: Convert stm32 watchdog bindings to json-schema
Date: Tue, 10 Dec 2019 08:28:20 +0000 [thread overview]
Message-ID: <bc07ec1b-12b5-3079-1a96-44a2906a1da2@st.com> (raw)
In-Reply-To: <20191122101616.14351-1-benjamin.gaignard@st.com>
On 11/22/19 11:16 AM, Benjamin Gaignard wrote:
> Convert the STM32 watchdog binding to DT schema format using json-schema
gentle ping to reviewers,
Thanks,
Benjamin
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> changes in version 3:
> - fix typo in clock-names enum
>
> changes in version 2:
> - remove trailer space
> - add Christophe in the maintainers list
>
> .../devicetree/bindings/watchdog/st,stm32-iwdg.txt | 26 ----------
> .../bindings/watchdog/st,stm32-iwdg.yaml | 55 ++++++++++++++++++++++
> 2 files changed, 55 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> deleted file mode 100644
> index d8f4430b0a13..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -STM32 Independent WatchDoG (IWDG)
> ----------------------------------
> -
> -Required properties:
> -- compatible: Should be either:
> - - "st,stm32-iwdg"
> - - "st,stm32mp1-iwdg"
> -- reg: Physical base address and length of the registers set for the device
> -- clocks: Reference to the clock entry lsi. Additional pclk clock entry
> - is required only for st,stm32mp1-iwdg.
> -- clock-names: Name of the clocks used.
> - "lsi" for st,stm32-iwdg
> - "lsi", "pclk" for st,stm32mp1-iwdg
> -
> -Optional Properties:
> -- timeout-sec: Watchdog timeout value in seconds.
> -
> -Example:
> -
> -iwdg: watchdog@40003000 {
> - compatible = "st,stm32-iwdg";
> - reg = <0x40003000 0x400>;
> - clocks = <&clk_lsi>;
> - clock-names = "lsi";
> - timeout-sec = <32>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> new file mode 100644
> index 000000000000..928588091710
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/st,stm32-iwdg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 Independent WatchDoG (IWDG) bindings
> +
> +maintainers:
> + - Yannick Fertre <yannick.fertre@st.com>
> + - Christophe Roullier <christophe.roullier@st.com>
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - st,stm32-iwdg
> + - st,stm32mp1-iwdg
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Low speed clock
> + - description: Optional peripheral clock
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + enum: [ lsi, pclk ]
> + minItems: 1
> + maxItems: 2
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/stm32mp1-clks.h>
> + watchdog@5a002000 {
> + compatible = "st,stm32mp1-iwdg";
> + reg = <0x5a002000 0x400>;
> + clocks = <&rcc IWDG2>, <&rcc CK_LSI>;
> + clock-names = "pclk", "lsi";
> + timeout-sec = <32>;
> + };
> +
> +...
prev parent reply other threads:[~2019-12-10 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 10:16 [PATCH v3] dt-bindings: watchdog: Convert stm32 watchdog bindings to json-schema Benjamin Gaignard
2019-12-10 8:28 ` Benjamin GAIGNARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc07ec1b-12b5-3079-1a96-44a2906a1da2@st.com \
--to=benjamin.gaignard@st.com \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).