From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A8DDC433ED for ; Sun, 16 May 2021 23:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB74361159 for ; Sun, 16 May 2021 23:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232513AbhEPXav (ORCPT ); Sun, 16 May 2021 19:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230241AbhEPXau (ORCPT ); Sun, 16 May 2021 19:30:50 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B66C061573; Sun, 16 May 2021 16:29:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=lr4+FFD80CxEdd/zr2bpfohQbxAklrTTMigzrv1n1/k=; b=NKx+NQNVDVhEHil84pPnU0zQdR X3y1roi+jyF5bl0qSH+9unO73LmaLjubNaQegYuOytVLF/nMMPiviN5sazg8ljgs6S7ngW5XUYlz1 yO54qccZKNuaMQcQU1B/T+RuZkE61Lpblc+99Fvp2jsjOG20hCdRdCKlQGOjf3bntakWEZeyMsua/ Og+dhpMjjToZZchTACbnawCLyjvZGxfdHHCoy55HF0HUwYhb0mD/0x5TKCq/v15Anz4utFVpAK4/j 5pVu8jVN/mTgrVXiIrglEHDIvMWRXdx0SXbvB4O1+/o3CKkEl8c9RB2GBzwxUfbh3Ph7dB4217dQV eRY22AYQ==; Received: from [2601:1c0:6280:3f0::7376] by bombadil.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1liQCS-00DLkD-Li; Sun, 16 May 2021 23:29:32 +0000 Subject: Re: [PATCH] watchdog: mtx-1: drop au1000.h header file To: Guenter Roeck , linux-kernel@vger.kernel.org Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Florian Fainelli References: <20210516211703.25349-1-rdunlap@infradead.org> From: Randy Dunlap Message-ID: Date: Sun, 16 May 2021 16:29:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 5/16/21 4:08 PM, Guenter Roeck wrote: > On 5/16/21 2:17 PM, Randy Dunlap wrote: >> The mtx-1_wdt driver does not need the au1000.h header file. >> Instead, the header file causes build errors, so drop it. >> >> This change fixes multiple build errors, all in au1000.h. E.g.: >> >> In file included from ../drivers/watchdog/mtx-1_wdt.c:44: >> ../arch/mips/include/asm/mach-au1x00/au1000.h: In function 'alchemy_rdsys': >> ../arch/mips/include/asm/mach-au1x00/au1000.h:603:36: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? [-Werror=implicit-function-declaration] >>    603 |  void __iomem *b = (void __iomem *)KSEG1ADDR(AU1000_SYS_PHYS_ADDR); >> ../arch/mips/include/asm/mach-au1x00/au1000.h:603:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] >>    603 |  void __iomem *b = (void __iomem *)KSEG1ADDR(AU1000_SYS_PHYS_ADDR); >> >> Fixes: 04bf3b4f5fc0 ("[WATCHDOG] MTX-1 Watchdog driver") > > More like > > Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") Duh. Thanks. >> Signed-off-by: Randy Dunlap >> Cc: Wim Van Sebroeck >> Cc: Guenter Roeck >> Cc: linux-watchdog@vger.kernel.org >> Cc: Florian Fainelli > > Reviewed-by: Guenter Roeck > >> --- >>   drivers/watchdog/mtx-1_wdt.c |    2 -- >>   1 file changed, 2 deletions(-) >> >> --- linux-next-20210514.orig/drivers/watchdog/mtx-1_wdt.c >> +++ linux-next-20210514/drivers/watchdog/mtx-1_wdt.c >> @@ -41,8 +41,6 @@ >>   #include >>   #include >>   -#include >> - >>   #define MTX1_WDT_INTERVAL    (5 * HZ) >>     static int ticks = 100 * HZ;