Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API
Date: Tue, 16 Mar 2021 18:47:17 +0100
Message-ID: <d25d96fa-0b88-930b-3160-fda3e69d3cba@pengutronix.de> (raw)
In-Reply-To: <cover.dedd9f1159389b0a438076ef5e5a46aded186463.1612457906.git-series.a.fatoum@pengutronix.de>

Hello,

On 04.02.21 18:00, Ahmad Fatoum wrote:
> This series migrates the driver to the new kernel watchdog API and
> then to the driver model.
> 
> Main feedback from Guenther on v2 was that I need to split it up to
> enable review. I have done so by removing the extra refactoring for
> now and focused on the functional changes described above. The diff
> is now much better readable.
> 
> I tested it on a f81866.

Gentle ping.

> 
> v2 -> v3:
>   https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@pengutronix.de/
>   - factored out identifier renaming again for easier review
>   - reordered commits
>   - removed refactoring that can go in later. Focusing now on kernel watchdog
>     API and platform device/driver migration
>   - removed platform_device_id and changed code to match by name
> 
> v1 -> v2:
>   https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@pengutronix.de/
>   - reworked to platform device/driver pair (Guenther)
>   - squashed identifier renaming into the patches that touch
>     the respective lines anyway
>   - fixed checkpatch.pl nitpicks (Guenther)
>   - fixed locally used variable declared without static (0-day)
>   - fixed unneded line break due to old line limit (Guenther)
>   - renamed struct fintek_wdog_data to struct fintek_wdt
> 
> Ahmad Fatoum (3):
>   watchdog: f71808e_wdt: rename variant-independent identifiers appropriately
>   watchdog: f71808e_wdt: migrate to new kernel watchdog API
>   watchdog: f71808e_wdt: refactor to platform device/driver pair
> 
>  drivers/watchdog/Kconfig       |   1 +-
>  drivers/watchdog/f71808e_wdt.c | 450 +++++++---------------------------
>  2 files changed, 100 insertions(+), 351 deletions(-)
> 
> base-commit: 1048ba83fb1c00cd24172e23e8263972f6b5d9ac
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 17:00 Ahmad Fatoum
2021-02-04 17:00 ` [PATCH v3 1/3] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Ahmad Fatoum
2021-02-04 17:00 ` [PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API Ahmad Fatoum
2021-02-04 17:00 ` [PATCH v3 3/3] watchdog: f71808e_wdt: refactor to platform device/driver pair Ahmad Fatoum
2021-03-16 17:47 ` Ahmad Fatoum [this message]
2021-04-05  8:28   ` [PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d25d96fa-0b88-930b-3160-fda3e69d3cba@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git