From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BE5C5ACD6 for ; Wed, 18 Mar 2020 20:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C38A208D6 for ; Wed, 18 Mar 2020 20:35:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qag0mCWI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbgCRUf5 (ORCPT ); Wed, 18 Mar 2020 16:35:57 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43684 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbgCRUf4 (ORCPT ); Wed, 18 Mar 2020 16:35:56 -0400 Received: by mail-pg1-f195.google.com with SMTP id u12so14308195pgb.10; Wed, 18 Mar 2020 13:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Iw9AuzL3JiFUgv3pCgPoZimqsHWInrI+wutYJ2aQyaY=; b=qag0mCWIQqfaRMoBtcLT75wTit+rIMHWY1AntpYo8Pg8RIrcumtEKnEUKaL1Q1Zg/B Cl2dsTNW7hIdy6FGNBQ9C5/S4kiph3Q4zjSyFHqFXUAwZyoJzaPcvYOjZSpoUUxZ4gqv h/LVUotg4QTg/4JcEx31oqQE14EBsiuaDUwYKDU+SRnyXbKtK+bveEVMEBPJuVTdBCq9 zL8eO1ybhNleKXPusICZLyH48QXrp4sWMgGgddBgXw16FrDC9s7Coh/edUimllfEzA6A G8tj30JziM3sPXQCAnG1xnFFW+c7LR3goZKk1G/lI9TjXAPyg7k/5x4ruCAshUeRjhi5 /kFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Iw9AuzL3JiFUgv3pCgPoZimqsHWInrI+wutYJ2aQyaY=; b=UbzBAL6ZdBTn7mU/WlWZn/pmR7iihVYaNdjJ6c/WvyJFcvO6lkB3A9ngcfHkGHNU17 4f3oc9cDskMw0wpZn4WbZifr5O+WmbiS7G7AjABRt/CBhn3xcQgYW5lVGNf+amgrPy7Y qZ9RoyrpXmowAEV10o21QKZ0RNSD/N6DH7sBWqH4UggrGAN1e+FZzmtWQcxEeQNwDrdN 4pdTWY2LZXzZJJo9nVIDOiIIUARwcODUbL8WI/XJdWYVLZUZRNzxxiIJMzPab+hfJKWK eM9/Xi0cQJHfBKxI72NfqsR1G+RSD39I8mJwO5iK+D0HGfWM8AAtsizK07rCdu8+anw+ Sdtw== X-Gm-Message-State: ANhLgQ2ycswMdv+dZC5G8j4ri9RY7Wx+ZenPMVfAHxa2lZA0wIomtBPM qXQimy01GLBJWQECvVfabSBQx7pN X-Google-Smtp-Source: ADFU+vv5ehuIyGfBV1LYTmRWND8Upq6vGmZisEO7B+JJAhL3mQWWcHDTXj37YoKKtHzDPHep0ZkIOA== X-Received: by 2002:a63:4e01:: with SMTP id c1mr6191676pgb.435.1584563754337; Wed, 18 Mar 2020 13:35:54 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id e189sm7432741pfa.139.2020.03.18.13.35.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2020 13:35:53 -0700 (PDT) Subject: Re: [PATCH 06/18] irqchip: add sl28cpld interrupt controller support To: Michael Walle Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Guenter Roeck References: <20200317205017.28280-1-michael@walle.cc> <20200317205017.28280-7-michael@walle.cc> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Wed, 18 Mar 2020 13:35:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 3/18/20 10:06 AM, Michael Walle wrote: > Am 2020-03-18 17:53, schrieb Guenter Roeck: >> On 3/17/20 1:50 PM, Michael Walle wrote: >>> This patch adds support for the interrupt controller inside the sl28 >>> CPLD management controller. >>> >>> Signed-off-by: Michael Walle >>> --- >>>  drivers/irqchip/Kconfig        |  3 ++ >>>  drivers/irqchip/Makefile       |  1 + >>>  drivers/irqchip/irq-sl28cpld.c | 92 ++++++++++++++++++++++++++++++++++ >>>  drivers/mfd/Kconfig            |  4 +- >>>  4 files changed, 98 insertions(+), 2 deletions(-) >>>  create mode 100644 drivers/irqchip/irq-sl28cpld.c >>> >>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >>> index 24fe08702ef7..3fd7415c8b55 100644 >>> --- a/drivers/irqchip/Kconfig >>> +++ b/drivers/irqchip/Kconfig >>> @@ -246,6 +246,9 @@ config RENESAS_RZA1_IRQC >>>        Enable support for the Renesas RZ/A1 Interrupt Controller, to use up >>>        to 8 external interrupts with configurable sense select. >>> >>> +config SL28CPLD_INTC >>> +    bool >>> + >>>  config ST_IRQCHIP >>>      bool >>>      select REGMAP >>> diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile >>> index eae0d78cbf22..0f4a37782609 100644 >>> --- a/drivers/irqchip/Makefile >>> +++ b/drivers/irqchip/Makefile >>> @@ -105,3 +105,4 @@ obj-$(CONFIG_MADERA_IRQ)        += irq-madera.o >>>  obj-$(CONFIG_LS1X_IRQ)            += irq-ls1x.o >>>  obj-$(CONFIG_TI_SCI_INTR_IRQCHIP)    += irq-ti-sci-intr.o >>>  obj-$(CONFIG_TI_SCI_INTA_IRQCHIP)    += irq-ti-sci-inta.o >>> +obj-$(CONFIG_SL28CPLD_INTC)        += irq-sl28cpld.o >>> diff --git a/drivers/irqchip/irq-sl28cpld.c b/drivers/irqchip/irq-sl28cpld.c >>> new file mode 100644 >>> index 000000000000..fa52ed79137b >>> --- /dev/null >>> +++ b/drivers/irqchip/irq-sl28cpld.c >>> @@ -0,0 +1,92 @@ >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +/* >>> + * SMARC-sAL28 Interrupt core driver. >>> + * >>> + * Copyright 2019 Kontron Europe GmbH >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#define INTC_IE 0 >>> +#define INTC_IP 1 >>> + >>> +static const struct regmap_irq sl28cpld_irqs[] = { >>> +    REGMAP_IRQ_REG_LINE(0, 8), >>> +    REGMAP_IRQ_REG_LINE(1, 8), >>> +    REGMAP_IRQ_REG_LINE(2, 8), >>> +    REGMAP_IRQ_REG_LINE(3, 8), >>> +    REGMAP_IRQ_REG_LINE(4, 8), >>> +    REGMAP_IRQ_REG_LINE(5, 8), >>> +    REGMAP_IRQ_REG_LINE(6, 8), >>> +    REGMAP_IRQ_REG_LINE(7, 8), >>> +}; >>> + >>> +struct sl28cpld_intc { >>> +    struct regmap *regmap; >>> +    struct regmap_irq_chip chip; >>> +    struct regmap_irq_chip_data *irq_data; >>> +}; >>> + >>> +static int sl28cpld_intc_probe(struct platform_device *pdev) >>> +{ >>> +    struct sl28cpld_intc *irqchip; >>> +    struct resource *res; >>> +    unsigned int irq; >>> +    int ret; >>> + >>> +    irqchip = devm_kzalloc(&pdev->dev, sizeof(*irqchip), GFP_KERNEL); >>> +    if (!irqchip) >>> +        return -ENOMEM; >>> + >>> +    if (!pdev->dev.parent) >>> +        return -ENODEV; >>> + >>> +    irqchip->regmap = dev_get_regmap(pdev->dev.parent, NULL); >>> +    if (!irqchip->regmap) >>> +        return -ENODEV; >>> + >>> +    irq = platform_get_irq(pdev, 0); >>> +    if (irq < 0) >>> +        return irq; >>> + >>> +    res = platform_get_resource(pdev, IORESOURCE_REG, 0); >>> +    if (!res) >>> +        return -EINVAL; >>> + >>> +    irqchip->chip.name = "sl28cpld-intc"; >>> +    irqchip->chip.irqs = sl28cpld_irqs; >>> +    irqchip->chip.num_irqs = ARRAY_SIZE(sl28cpld_irqs); >>> +    irqchip->chip.num_regs = 1; >>> +    irqchip->chip.status_base = res->start + INTC_IP; >>> +    irqchip->chip.mask_base = res->start + INTC_IE; >>> +    irqchip->chip.mask_invert = true, >>> +    irqchip->chip.ack_base = res->start + INTC_IP; >>> + >>> +    ret = devm_regmap_add_irq_chip(&pdev->dev, irqchip->regmap, irq, >>> +                       IRQF_SHARED | IRQF_ONESHOT, 0, >>> +                       &irqchip->chip, &irqchip->irq_data); >>> +    if (ret) >>> +        return ret; >>> +    dev_info(&pdev->dev, "registered IRQ %d\n", irq); >>> + >>> +    return 0; >>> +} >>> + >>> +static struct platform_driver sl28cpld_intc_driver = { >>> +    .probe    = sl28cpld_intc_probe, >>> +    .driver = { >>> +        .name = "sl28cpld-intc", >>> +    } >>> +}; >>> +module_platform_driver(sl28cpld_intc_driver); >>> + >>> +MODULE_DESCRIPTION("sl28cpld Interrupt Controller Driver"); >>> +MODULE_LICENSE("GPL"); >>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >>> index 01588c366476..4f741d640705 100644 >>> --- a/drivers/mfd/Kconfig >>> +++ b/drivers/mfd/Kconfig >>> @@ -2060,12 +2060,12 @@ config SGI_MFD_IOC3 >>>        then say Y. Otherwise say N. >>> >>>  config MFD_SL28CPLD >>> -    tristate "Kontron sl28 core driver" >>> +    bool "Kontron sl28 core driver" >> >> This is .... unusual. Why declare it tristate only to re-declare it >> bool in the next patch ? > > I though it was a good idea to have that gradually build up, esp. since > these patches might go through different reviewers/trees. That being said, > I'll change it though. > Gradually build up is fine, but that doesn't mean to do it one way first and change it later. This only results in feedback like mine - I2C=y just didn't make sense in the previous patch. Please keep in mind that doing things one way first and then changing them later only wastes people's time. It would be much better to mention in the previous patch that the symbol is declared bool because a subsequent patch introduces an interrupt controller driver which needs to be built-in. Thanks, Guenter >> It does explain the I2C=y, but I really think it should be bool from >> the start if it ends up >> there. > > Ok. > >> >>>      depends on I2C=y >>>      depends on OF >>>      select REGMAP_I2C >>>      select REGMAP_IRQ >>> -    select SL28CPLD_IRQ >>> +    select SL28CPLD_INTC >> >> What is the point of introducing SL28CPLD_IRQ in the first place ? > > oh damn. this is a left-over which slipped through. There should just > be a SL28CPLD_INTC. > > -michael > >> >>>      select MFD_CORE >>>      help >>>        This option enables support for the board management controller >>>