Linux-Watchdog Archive on
 help / color / Atom feed
From: Guenter Roeck <>
To: Rasmus Villemoes <>,
	"" <>
Subject: Re: watchdog ioctl inconsistencies
Date: Mon, 26 Aug 2019 17:19:05 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On 8/26/19 5:54 AM, Rasmus Villemoes wrote:
> Hi,
> uapi/linux/watchdog.h has these
> This is a write from userspace perspective, so should have been _IOW.
> This one doesn't actually take an argument, so should just have been an
> _IO - or if anything, an _IOW. One could be misled to think that if the
> int argument has 'V' somewhere (perhaps first or last byte, depending on
> endianness) that would count as a magic close.
> The SETTIMEOUT handling does fall through to the GETTIMEOUT case, so
> that one is indeed a "write this, but tell me what value actually took
> effect". The SETPRETIMEOUT case ends with a break, so that one is really
> _IOW.
> There's not much to do about these, I think, but perhaps one could add a
> comment to the uapi header containing the magic explains-all phrase
> "historical reasons".
Those ioctls were imported into git when the git repository was created.
I don't think it is worth bothering about it now. I also don't think it
would add much if any value to add "historic reason" comments.


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 12:54 Rasmus Villemoes
2019-08-27  0:19 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on

Archives are clonable:
	git clone --mirror linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ \
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone