Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
@ 2020-08-27  6:21 Zhen Lei
  2020-08-27 13:40 ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Zhen Lei @ 2020-08-27  6:21 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Peter Zijlstra, Ingo Molnar,
	linux-watchdog, linux-kernel
  Cc: Zhen Lei

There has been no reference to "struct sched_param" since
commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
there's no need to include <uapi/linux/sched/types.h> any more, delete
it.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/watchdog/watchdog_dev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index 6798addabd5a067..0f18fa2433310b0 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -43,8 +43,6 @@
 #include <linux/watchdog.h>	/* For watchdog specific items */
 #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
 
-#include <uapi/linux/sched/types.h>	/* For struct sched_param */
-
 #include "watchdog_core.h"
 #include "watchdog_pretimeout.h"
 
-- 
1.8.3



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
  2020-08-27  6:21 [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h> Zhen Lei
@ 2020-08-27 13:40 ` Guenter Roeck
  2020-09-07  7:50   ` Leizhen (ThunderTown)
  0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2020-08-27 13:40 UTC (permalink / raw)
  To: Zhen Lei, Wim Van Sebroeck, Peter Zijlstra, Ingo Molnar,
	linux-watchdog, linux-kernel

On 8/26/20 11:21 PM, Zhen Lei wrote:
> There has been no reference to "struct sched_param" since
> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
> there's no need to include <uapi/linux/sched/types.h> any more, delete
> it.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/watchdog_dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index 6798addabd5a067..0f18fa2433310b0 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -43,8 +43,6 @@
>  #include <linux/watchdog.h>	/* For watchdog specific items */
>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>  
> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
> -
>  #include "watchdog_core.h"
>  #include "watchdog_pretimeout.h"
>  
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
  2020-08-27 13:40 ` Guenter Roeck
@ 2020-09-07  7:50   ` Leizhen (ThunderTown)
  2020-09-08  2:40     ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Leizhen (ThunderTown) @ 2020-09-07  7:50 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, Peter Zijlstra, Ingo Molnar,
	linux-watchdog, linux-kernel

Hi, Wim Van Sebroeck, Guenter Roeck:
  What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.


On 2020/8/27 21:40, Guenter Roeck wrote:
> On 8/26/20 11:21 PM, Zhen Lei wrote:
>> There has been no reference to "struct sched_param" since
>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
>> there's no need to include <uapi/linux/sched/types.h> any more, delete
>> it.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
>> ---
>>  drivers/watchdog/watchdog_dev.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
>> index 6798addabd5a067..0f18fa2433310b0 100644
>> --- a/drivers/watchdog/watchdog_dev.c
>> +++ b/drivers/watchdog/watchdog_dev.c
>> @@ -43,8 +43,6 @@
>>  #include <linux/watchdog.h>	/* For watchdog specific items */
>>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>>  
>> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
>> -
>>  #include "watchdog_core.h"
>>  #include "watchdog_pretimeout.h"
>>  
>>
> 
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
  2020-09-07  7:50   ` Leizhen (ThunderTown)
@ 2020-09-08  2:40     ` Guenter Roeck
  2020-09-08  3:34       ` Leizhen (ThunderTown)
  0 siblings, 1 reply; 7+ messages in thread
From: Guenter Roeck @ 2020-09-08  2:40 UTC (permalink / raw)
  To: Leizhen (ThunderTown),
	Wim Van Sebroeck, Peter Zijlstra, Ingo Molnar, linux-watchdog,
	linux-kernel

On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote:
> Hi, Wim Van Sebroeck, Guenter Roeck:
>   What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
> 

The patch is in my watchdog-next branch, and Wim usually picks it up
from there.

Guenter

> 
> On 2020/8/27 21:40, Guenter Roeck wrote:
>> On 8/26/20 11:21 PM, Zhen Lei wrote:
>>> There has been no reference to "struct sched_param" since
>>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
>>> there's no need to include <uapi/linux/sched/types.h> any more, delete
>>> it.
>>>
>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>>> ---
>>>  drivers/watchdog/watchdog_dev.c | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
>>> index 6798addabd5a067..0f18fa2433310b0 100644
>>> --- a/drivers/watchdog/watchdog_dev.c
>>> +++ b/drivers/watchdog/watchdog_dev.c
>>> @@ -43,8 +43,6 @@
>>>  #include <linux/watchdog.h>	/* For watchdog specific items */
>>>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>>>  
>>> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
>>> -
>>>  #include "watchdog_core.h"
>>>  #include "watchdog_pretimeout.h"
>>>  
>>>
>>
>>
>>
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
  2020-09-08  2:40     ` Guenter Roeck
@ 2020-09-08  3:34       ` Leizhen (ThunderTown)
  2020-10-14  2:14         ` Leizhen (ThunderTown)
  0 siblings, 1 reply; 7+ messages in thread
From: Leizhen (ThunderTown) @ 2020-09-08  3:34 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, Peter Zijlstra, Ingo Molnar,
	linux-watchdog, linux-kernel



On 2020/9/8 10:40, Guenter Roeck wrote:
> On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote:
>> Hi, Wim Van Sebroeck, Guenter Roeck:
>>   What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
>>
> 
> The patch is in my watchdog-next branch, and Wim usually picks it up
> from there.

Oh, thanks.

> 
> Guenter
> 
>>
>> On 2020/8/27 21:40, Guenter Roeck wrote:
>>> On 8/26/20 11:21 PM, Zhen Lei wrote:
>>>> There has been no reference to "struct sched_param" since
>>>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
>>>> there's no need to include <uapi/linux/sched/types.h> any more, delete
>>>> it.
>>>>
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>>> ---
>>>>  drivers/watchdog/watchdog_dev.c | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
>>>> index 6798addabd5a067..0f18fa2433310b0 100644
>>>> --- a/drivers/watchdog/watchdog_dev.c
>>>> +++ b/drivers/watchdog/watchdog_dev.c
>>>> @@ -43,8 +43,6 @@
>>>>  #include <linux/watchdog.h>	/* For watchdog specific items */
>>>>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>>>>  
>>>> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
>>>> -
>>>>  #include "watchdog_core.h"
>>>>  #include "watchdog_pretimeout.h"
>>>>  
>>>>
>>>
>>>
>>>
>>
> 
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
  2020-09-08  3:34       ` Leizhen (ThunderTown)
@ 2020-10-14  2:14         ` Leizhen (ThunderTown)
  2020-10-14  7:51           ` Guenter Roeck
  0 siblings, 1 reply; 7+ messages in thread
From: Leizhen (ThunderTown) @ 2020-10-14  2:14 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, Peter Zijlstra, Ingo Molnar,
	linux-watchdog, linux-kernel



On 2020/9/8 11:34, Leizhen (ThunderTown) wrote:
> 
> 
> On 2020/9/8 10:40, Guenter Roeck wrote:
>> On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote:
>>> Hi, Wim Van Sebroeck, Guenter Roeck:
>>>   What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
>>>
>>
>> The patch is in my watchdog-next branch, and Wim usually picks it up
>> from there.
> 

Hi, Guenter:
  Have you sent [GIT PULL] updates for 5.10, I don't see this patch in linux-next.

> Oh, thanks.
> 
>>
>> Guenter
>>
>>>
>>> On 2020/8/27 21:40, Guenter Roeck wrote:
>>>> On 8/26/20 11:21 PM, Zhen Lei wrote:
>>>>> There has been no reference to "struct sched_param" since
>>>>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
>>>>> there's no need to include <uapi/linux/sched/types.h> any more, delete
>>>>> it.
>>>>>
>>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>>
>>>>> ---
>>>>>  drivers/watchdog/watchdog_dev.c | 2 --
>>>>>  1 file changed, 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
>>>>> index 6798addabd5a067..0f18fa2433310b0 100644
>>>>> --- a/drivers/watchdog/watchdog_dev.c
>>>>> +++ b/drivers/watchdog/watchdog_dev.c
>>>>> @@ -43,8 +43,6 @@
>>>>>  #include <linux/watchdog.h>	/* For watchdog specific items */
>>>>>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>>>>>  
>>>>> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
>>>>> -
>>>>>  #include "watchdog_core.h"
>>>>>  #include "watchdog_pretimeout.h"
>>>>>  
>>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
  2020-10-14  2:14         ` Leizhen (ThunderTown)
@ 2020-10-14  7:51           ` Guenter Roeck
  0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2020-10-14  7:51 UTC (permalink / raw)
  To: Leizhen (ThunderTown),
	Wim Van Sebroeck, Peter Zijlstra, Ingo Molnar, linux-watchdog,
	linux-kernel

On 10/13/20 7:14 PM, Leizhen (ThunderTown) wrote:
> 
> 
> On 2020/9/8 11:34, Leizhen (ThunderTown) wrote:
>>
>>
>> On 2020/9/8 10:40, Guenter Roeck wrote:
>>> On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote:
>>>> Hi, Wim Van Sebroeck, Guenter Roeck:
>>>>   What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
>>>>
>>>
>>> The patch is in my watchdog-next branch, and Wim usually picks it up
>>> from there.
>>
> 
> Hi, Guenter:
>   Have you sent [GIT PULL] updates for 5.10, I don't see this patch in linux-next.
> 

Wim does that. Unfortunately, he often does not pick up patches until shortly
before he sends a pull request to Linus.

Guenter

>> Oh, thanks.
>>
>>>
>>> Guenter
>>>
>>>>
>>>> On 2020/8/27 21:40, Guenter Roeck wrote:
>>>>> On 8/26/20 11:21 PM, Zhen Lei wrote:
>>>>>> There has been no reference to "struct sched_param" since
>>>>>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
>>>>>> there's no need to include <uapi/linux/sched/types.h> any more, delete
>>>>>> it.
>>>>>>
>>>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>>>
>>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>>>
>>>>>> ---
>>>>>>  drivers/watchdog/watchdog_dev.c | 2 --
>>>>>>  1 file changed, 2 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
>>>>>> index 6798addabd5a067..0f18fa2433310b0 100644
>>>>>> --- a/drivers/watchdog/watchdog_dev.c
>>>>>> +++ b/drivers/watchdog/watchdog_dev.c
>>>>>> @@ -43,8 +43,6 @@
>>>>>>  #include <linux/watchdog.h>	/* For watchdog specific items */
>>>>>>  #include <linux/uaccess.h>	/* For copy_to_user/put_user/... */
>>>>>>  
>>>>>> -#include <uapi/linux/sched/types.h>	/* For struct sched_param */
>>>>>> -
>>>>>>  #include "watchdog_core.h"
>>>>>>  #include "watchdog_pretimeout.h"
>>>>>>  
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-27  6:21 [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h> Zhen Lei
2020-08-27 13:40 ` Guenter Roeck
2020-09-07  7:50   ` Leizhen (ThunderTown)
2020-09-08  2:40     ` Guenter Roeck
2020-09-08  3:34       ` Leizhen (ThunderTown)
2020-10-14  2:14         ` Leizhen (ThunderTown)
2020-10-14  7:51           ` Guenter Roeck

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git