From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
jorge@foundries.io, linux-watchdog@vger.kernel.org,
linux-arm-msm@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ
Date: Thu, 28 Jan 2021 16:33:58 +0530 [thread overview]
Message-ID: <e3e9e4a9ef8adcf78d32f7996dc66083@codeaurora.org> (raw)
In-Reply-To: <161179763694.76967.7406861246436700530@swboyd.mtv.corp.google.com>
On 2021-01-28 07:03, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2021-01-26 07:02:41)
>> As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1)
>> of watchdog control register is wakeup interrupt enable bit and
>> not related to bark interrupt at all, BIT(0) is used for that.
>> So remove incorrect usage of this bit when supporting bark irq for
>> pre-timeout notification. Currently with this bit set and bark
>> interrupt specified, pre-timeout notification and/or watchdog
>> reset/bite does not occur.
>
> It looks like the QCOM_WDT_ENABLE_IRQ bit is to catch a problem where a
> pending irq is unmasked but the watchdog irq isn't handled in time? So
> some sort of irq storm?
>
In sleep mode, this bit is used to enable unmasked irq to wakeup
watchdog timer. The watchdog counter can be brought out of
reset either by writing 1 to WDOG_RESET or setting this BIT(1) to 1.
>>
>> Fixes: 36375491a439 ("watchdog: qcom: support pre-timeout when the
>> bark irq is available")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-01-28 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 15:02 [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ Sai Prakash Ranjan
2021-01-26 15:23 ` Guenter Roeck
2021-01-26 15:53 ` Sai Prakash Ranjan
2021-01-28 1:33 ` Stephen Boyd
2021-01-28 11:03 ` Sai Prakash Ranjan [this message]
2021-01-28 8:19 ` Jorge Ramirez-Ortiz, Foundries
2021-01-28 11:08 ` Sai Prakash Ranjan
2021-02-01 5:53 Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e9e4a9ef8adcf78d32f7996dc66083@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=jorge@foundries.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).