Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
From: Patrice CHOTARD <patrice.chotard@st.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 19/23] watchdog: st_lpc_wdt: Convert to use device managed functions
Date: Wed, 10 Apr 2019 07:26:03 +0000
Message-ID: <e96fd22f-2717-3ad7-028a-b44fe963a265@st.com> (raw)
In-Reply-To: <1554830641-9247-20-git-send-email-linux@roeck-us.net>

Hi Guenter

On 4/9/19 7:23 PM, Guenter Roeck wrote:
> Use device managed functions to simplify error handling, reduce
> source code size, improve readability, and reduce the likelyhood of bugs.
> 
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts
> used to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
> 
> - Use devm_add_action_or_reset() for calls to clk_disable_unprepare
> - Introduce local variable 'struct device *dev' and use it instead of
>   dereferencing it repeatedly
> - Use devm_watchdog_register_driver() to register watchdog device
> 
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/watchdog/st_lpc_wdt.c | 47 ++++++++++++++++++++++++-------------------
>  1 file changed, 26 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/watchdog/st_lpc_wdt.c b/drivers/watchdog/st_lpc_wdt.c
> index 196fb4b72c5d..9a5ed95c3403 100644
> --- a/drivers/watchdog/st_lpc_wdt.c
> +++ b/drivers/watchdog/st_lpc_wdt.c
> @@ -142,10 +142,16 @@ static struct watchdog_device st_wdog_dev = {
>  	.ops		= &st_wdog_ops,
>  };
>  
> +static void st_clk_disable_unprepare(void *data)
> +{
> +	clk_disable_unprepare(data);
> +}
> +
>  static int st_wdog_probe(struct platform_device *pdev)
>  {
> +	struct device *dev = &pdev->dev;
>  	const struct of_device_id *match;
> -	struct device_node *np = pdev->dev.of_node;
> +	struct device_node *np = dev->of_node;
>  	struct st_wdog *st_wdog;
>  	struct regmap *regmap;
>  	struct clk *clk;
> @@ -155,7 +161,7 @@ static int st_wdog_probe(struct platform_device *pdev)
>  
>  	ret = of_property_read_u32(np, "st,lpc-mode", &mode);
>  	if (ret) {
> -		dev_err(&pdev->dev, "An LPC mode must be provided\n");
> +		dev_err(dev, "An LPC mode must be provided\n");
>  		return -EINVAL;
>  	}
>  
> @@ -163,13 +169,13 @@ static int st_wdog_probe(struct platform_device *pdev)
>  	if (mode != ST_LPC_MODE_WDT)
>  		return -ENODEV;
>  
> -	st_wdog = devm_kzalloc(&pdev->dev, sizeof(*st_wdog), GFP_KERNEL);
> +	st_wdog = devm_kzalloc(dev, sizeof(*st_wdog), GFP_KERNEL);
>  	if (!st_wdog)
>  		return -ENOMEM;
>  
> -	match = of_match_device(st_wdog_match, &pdev->dev);
> +	match = of_match_device(st_wdog_match, dev);
>  	if (!match) {
> -		dev_err(&pdev->dev, "Couldn't match device\n");
> +		dev_err(dev, "Couldn't match device\n");
>  		return -ENODEV;
>  	}
>  	st_wdog->syscfg	= (struct st_wdog_syscfg *)match->data;
> @@ -180,17 +186,17 @@ static int st_wdog_probe(struct platform_device *pdev)
>  
>  	regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
>  	if (IS_ERR(regmap)) {
> -		dev_err(&pdev->dev, "No syscfg phandle specified\n");
> +		dev_err(dev, "No syscfg phandle specified\n");
>  		return PTR_ERR(regmap);
>  	}
>  
> -	clk = devm_clk_get(&pdev->dev, NULL);
> +	clk = devm_clk_get(dev, NULL);
>  	if (IS_ERR(clk)) {
> -		dev_err(&pdev->dev, "Unable to request clock\n");
> +		dev_err(dev, "Unable to request clock\n");
>  		return PTR_ERR(clk);
>  	}
>  
> -	st_wdog->dev		= &pdev->dev;
> +	st_wdog->dev		= dev;
>  	st_wdog->base		= base;
>  	st_wdog->clk		= clk;
>  	st_wdog->regmap		= regmap;
> @@ -198,39 +204,40 @@ static int st_wdog_probe(struct platform_device *pdev)
>  	st_wdog->clkrate	= clk_get_rate(st_wdog->clk);
>  
>  	if (!st_wdog->clkrate) {
> -		dev_err(&pdev->dev, "Unable to fetch clock rate\n");
> +		dev_err(dev, "Unable to fetch clock rate\n");
>  		return -EINVAL;
>  	}
>  	st_wdog_dev.max_timeout = 0xFFFFFFFF / st_wdog->clkrate;
> -	st_wdog_dev.parent = &pdev->dev;
> +	st_wdog_dev.parent = dev;
>  
>  	ret = clk_prepare_enable(clk);
>  	if (ret) {
> -		dev_err(&pdev->dev, "Unable to enable clock\n");
> +		dev_err(dev, "Unable to enable clock\n");
>  		return ret;
>  	}
> +	ret = devm_add_action_or_reset(dev, st_clk_disable_unprepare, clk);
> +	if (ret)
> +		return ret;
>  
>  	watchdog_set_drvdata(&st_wdog_dev, st_wdog);
>  	watchdog_set_nowayout(&st_wdog_dev, WATCHDOG_NOWAYOUT);
>  
>  	/* Init Watchdog timeout with value in DT */
> -	ret = watchdog_init_timeout(&st_wdog_dev, 0, &pdev->dev);
> +	ret = watchdog_init_timeout(&st_wdog_dev, 0, dev);
>  	if (ret) {
> -		dev_err(&pdev->dev, "Unable to initialise watchdog timeout\n");
> -		clk_disable_unprepare(clk);
> +		dev_err(dev, "Unable to initialise watchdog timeout\n");
>  		return ret;
>  	}
>  
> -	ret = watchdog_register_device(&st_wdog_dev);
> +	ret = devm_watchdog_register_device(dev, &st_wdog_dev);
>  	if (ret) {
> -		dev_err(&pdev->dev, "Unable to register watchdog\n");
> -		clk_disable_unprepare(clk);
> +		dev_err(dev, "Unable to register watchdog\n");
>  		return ret;
>  	}
>  
>  	st_wdog_setup(st_wdog, true);
>  
> -	dev_info(&pdev->dev, "LPC Watchdog driver registered, reset type is %s",
> +	dev_info(dev, "LPC Watchdog driver registered, reset type is %s",
>  		 st_wdog->warm_reset ? "warm" : "cold");
>  
>  	return ret;
> @@ -241,8 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev)
>  	struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
>  
>  	st_wdog_setup(st_wdog, false);
> -	watchdog_unregister_device(&st_wdog_dev);
> -	clk_disable_unprepare(st_wdog->clk);
>  
>  	return 0;
>  }
> 

Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

  reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 17:23 [PATCH 00/23] watchdog: Expand use of device managed functions (series 2 of 3) Guenter Roeck
2019-04-09 17:23 ` [PATCH 01/23] watchdog: max77620_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-09 17:23 ` [PATCH 02/23] watchdog: mena21_wdt: Use 'dev' instead of dereferencing it repeatedly Guenter Roeck
2019-04-11  7:18   ` Johannes Thumshirn
2019-04-09 17:23 ` [PATCH 03/23] watchdog: menf21bmc_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-09 17:23 ` [PATCH 04/23] watchdog: meson_gxbb_wdt: " Guenter Roeck
2019-04-09 17:23 ` [PATCH 05/23] watchdog: meson_wdt: Use 'dev' instead of dereferencing it repeatedly Guenter Roeck
2019-04-09 17:23 ` [PATCH 06/23] watchdog: mlx_wdt: " Guenter Roeck
2019-04-09 17:23 ` [PATCH 07/23] watchdog: moxart_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-09 17:23 ` [PATCH 08/23] watchdog: mtk_wdt: " Guenter Roeck
2019-04-09 17:23 ` [PATCH 09/23] watchdog: npcm_wdt: Use local variable 'dev' consistently Guenter Roeck
2019-04-09 17:23 ` [PATCH 10/23] watchdog: of_xilinx_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-10  6:38   ` Michal Simek
2019-04-10 12:09     ` Guenter Roeck
2019-04-09 17:23 ` [PATCH 11/23] watchdog: pm8916_wdt: Use 'dev' instead of dereferencing it repeatedly Guenter Roeck
2019-04-09 17:23 ` [PATCH 12/23] watchdog: qcom-wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-09 17:23 ` [PATCH 13/23] watchdog: rn5t618_wdt: Use 'dev' instead of dereferencing it repeatedly Guenter Roeck
2019-04-09 17:23 ` [PATCH 14/23] watchdog: rtd119x_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-09 17:23 ` [PATCH 15/23] watchdog: rza_wdt: Use 'dev' instead of dereferencing it repeatedly Guenter Roeck
2019-04-09 17:23 ` [PATCH 16/23] watchdog: sama5d4_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-09 17:23 ` [PATCH 17/23] watchdog: sirfsoc_wdt: " Guenter Roeck
2019-04-09 17:23 ` [PATCH 18/23] watchdog: 1: " Guenter Roeck
2019-04-09 17:38   ` Guenter Roeck
2019-04-09 17:23 ` [PATCH 19/23] watchdog: st_lpc_wdt: Convert to use device managed functions Guenter Roeck
2019-04-10  7:26   ` Patrice CHOTARD [this message]
2019-04-09 17:23 ` [PATCH 20/23] watchdog: stmp3xxx_rtc_wdt: " Guenter Roeck
2019-04-09 17:23 ` [PATCH 21/23] watchdog: stpmic1_wdt: Use 'dev' instead of dereferencing it repeatedly Guenter Roeck
2019-04-09 17:24 ` [PATCH 22/23] watchdog: sunxi_wdt: " Guenter Roeck
2019-04-10  7:06   ` Maxime Ripard
2019-04-09 17:24 ` [PATCH 23/23] watchdog: tangox_wdt: Convert to use device managed functions and other improvements Guenter Roeck
2019-04-10 11:20   ` Måns Rullgård

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e96fd22f-2717-3ad7-028a-b44fe963a265@st.com \
    --to=patrice.chotard@st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git