From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0613C432C0 for ; Fri, 22 Nov 2019 10:28:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D174220714 for ; Fri, 22 Nov 2019 10:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726417AbfKVK2v (ORCPT ); Fri, 22 Nov 2019 05:28:51 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:40347 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfKVK2v (ORCPT ); Fri, 22 Nov 2019 05:28:51 -0500 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1iY6BF-0002Iy-Qd; Fri, 22 Nov 2019 11:28:49 +0100 From: Ahmad Fatoum Subject: Re: [Linux-stm32] [PATCH v2 1/1] drivers: watchdog: stm32_iwdg: set WDOG_HW_RUNNING at probe To: Christophe Roullier , wim@linux-watchdog.org, linux@roeck-us.net, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com Cc: linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20191122082442.21695-1-christophe.roullier@st.com> Message-ID: Date: Fri, 22 Nov 2019 11:28:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191122082442.21695-1-christophe.roullier@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-watchdog@vger.kernel.org Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Hello Christophe, On 11/22/19 9:24 AM, Christophe Roullier wrote: > + /* > + * In case of CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED is set > + * (Means U-Boot/bootloaders leaves the watchdog running) > + * When we get here we should make a decision to prevent > + * any side effects before user space daemon will take care of it. > + * The best option, taking into consideration that there is no > + * way to read values back from hardware, is to enforce watchdog > + * being run with deterministic values. What about the "ONF: Watchdog enable status bit" in the IWDG_SR register? Cheers Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |