From: Guenter Roeck <linux@roeck-us.net>
To: Ferry Toth <fntoth@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Razvan Becheriu <razvan.becheriu@qualitance.com>,
linux-watchdog@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>
Subject: Re: [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support
Date: Tue, 29 Oct 2019 17:13:12 -0700 [thread overview]
Message-ID: <f13a146b-296d-0cca-8443-5771b76a3c64@roeck-us.net> (raw)
In-Reply-To: <980eb3ec-ab3e-5aa6-e4ae-4cbecf29f778@gmail.com>
On 10/29/19 10:42 AM, Ferry Toth wrote:
> Op 30-09-2019 om 15:15 schreef Guenter Roeck:
>> On 9/24/19 7:31 AM, Andy Shevchenko wrote:
>>> Normally, the watchdog is disabled when /dev/watchdog is closed, but if
>>> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should
>>> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT
>>> is defined.
>>>
>>> Reported-by: Razvan Becheriu <razvan.becheriu@qualitance.com>
>>> Cc: Ferry Toth <fntoth@gmail.com>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Any chance of this going in v5.4?
>
Good question. There are a few other pending bug fixes, including one
which fixes a build failure. Wim, any chance you can queue those up ?
Thanks,
Guenter
>>> ---
>>> drivers/watchdog/intel-mid_wdt.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
>>> index 2cdbd37c700c..470213abfd3d 100644
>>> --- a/drivers/watchdog/intel-mid_wdt.c
>>> +++ b/drivers/watchdog/intel-mid_wdt.c
>>> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev)
>>> wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT;
>>> wdt_dev->parent = dev;
>>> + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT);
>>> watchdog_set_drvdata(wdt_dev, dev);
>>> ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq,
>>>
>>
>
>
next prev parent reply other threads:[~2019-10-30 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 14:31 [PATCH v1] watchdog: intel-mid_wdt: Add WATCHDOG_NOWAYOUT support Andy Shevchenko
2019-09-30 13:15 ` Guenter Roeck
2019-10-29 17:42 ` Ferry Toth
2019-10-30 0:13 ` Guenter Roeck [this message]
[not found] ` <CAJAoKi8aRHyySUM1mcuub_tgmE7fdLgRyajYF=fUf6QH0PvZPA@mail.gmail.com>
2019-10-01 20:32 ` Andy Shevchenko
[not found] ` <CAJAoKi_c2XRi_tdJcc3MMS1=9d4WH_Tq9EmH30-GyXcPoJhXGA@mail.gmail.com>
2019-10-02 6:11 ` razvan becheriu
2019-10-02 8:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f13a146b-296d-0cca-8443-5771b76a3c64@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fntoth@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=razvan.becheriu@qualitance.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).