linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: rza_wdt: Use semicolons instead of commas
@ 2021-09-15  9:48 Geert Uytterhoeven
  2021-09-15 14:00 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-09-15  9:48 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck
  Cc: Julia Lawall, linux-watchdog, linux-renesas-soc, Geert Uytterhoeven

This code works, but it is cleaner to use semicolons at the end of
statements instead of commas.

Extracted from a big anonymous patch by Julia Lawall
<julia.lawall@inria.fr>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/watchdog/rza_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/rza_wdt.c b/drivers/watchdog/rza_wdt.c
index 7b6c365f7cd36297..fe6c2ed35e04cc4b 100644
--- a/drivers/watchdog/rza_wdt.c
+++ b/drivers/watchdog/rza_wdt.c
@@ -189,8 +189,8 @@ static int rza_wdt_probe(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	priv->wdev.info = &rza_wdt_ident,
-	priv->wdev.ops = &rza_wdt_ops,
+	priv->wdev.info = &rza_wdt_ident;
+	priv->wdev.ops = &rza_wdt_ops;
 	priv->wdev.parent = dev;
 
 	priv->cks = (u8)(uintptr_t) of_device_get_match_data(dev);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: rza_wdt: Use semicolons instead of commas
  2021-09-15  9:48 [PATCH] watchdog: rza_wdt: Use semicolons instead of commas Geert Uytterhoeven
@ 2021-09-15 14:00 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-09-15 14:00 UTC (permalink / raw)
  To: Geert Uytterhoeven, Wim Van Sebroeck
  Cc: Julia Lawall, linux-watchdog, linux-renesas-soc

On 9/15/21 2:48 AM, Geert Uytterhoeven wrote:
> This code works, but it is cleaner to use semicolons at the end of
> statements instead of commas.
> 
> Extracted from a big anonymous patch by Julia Lawall
> <julia.lawall@inria.fr>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/rza_wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/rza_wdt.c b/drivers/watchdog/rza_wdt.c
> index 7b6c365f7cd36297..fe6c2ed35e04cc4b 100644
> --- a/drivers/watchdog/rza_wdt.c
> +++ b/drivers/watchdog/rza_wdt.c
> @@ -189,8 +189,8 @@ static int rza_wdt_probe(struct platform_device *pdev)
>   		return -ENOENT;
>   	}
>   
> -	priv->wdev.info = &rza_wdt_ident,
> -	priv->wdev.ops = &rza_wdt_ops,
> +	priv->wdev.info = &rza_wdt_ident;
> +	priv->wdev.ops = &rza_wdt_ops;
>   	priv->wdev.parent = dev;
>   
>   	priv->cks = (u8)(uintptr_t) of_device_get_match_data(dev);
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-15 14:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15  9:48 [PATCH] watchdog: rza_wdt: Use semicolons instead of commas Geert Uytterhoeven
2021-09-15 14:00 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).