From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-watchdog <linux-watchdog@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h>
Date: Mon, 7 Sep 2020 15:50:17 +0800 [thread overview]
Message-ID: <f80cc7ea-9d1f-64a4-7c18-faf672bf8cf6@huawei.com> (raw)
In-Reply-To: <55ad40ff-dcc1-5051-65d2-24201c471a8f@roeck-us.net>
Hi, Wim Van Sebroeck, Guenter Roeck:
What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago.
On 2020/8/27 21:40, Guenter Roeck wrote:
> On 8/26/20 11:21 PM, Zhen Lei wrote:
>> There has been no reference to "struct sched_param" since
>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so
>> there's no need to include <uapi/linux/sched/types.h> any more, delete
>> it.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
>> ---
>> drivers/watchdog/watchdog_dev.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
>> index 6798addabd5a067..0f18fa2433310b0 100644
>> --- a/drivers/watchdog/watchdog_dev.c
>> +++ b/drivers/watchdog/watchdog_dev.c
>> @@ -43,8 +43,6 @@
>> #include <linux/watchdog.h> /* For watchdog specific items */
>> #include <linux/uaccess.h> /* For copy_to_user/put_user/... */
>>
>> -#include <uapi/linux/sched/types.h> /* For struct sched_param */
>> -
>> #include "watchdog_core.h"
>> #include "watchdog_pretimeout.h"
>>
>>
>
>
>
next prev parent reply other threads:[~2020-09-07 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 6:21 [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h> Zhen Lei
2020-08-27 13:40 ` Guenter Roeck
2020-09-07 7:50 ` Leizhen (ThunderTown) [this message]
2020-09-08 2:40 ` Guenter Roeck
2020-09-08 3:34 ` Leizhen (ThunderTown)
2020-10-14 2:14 ` Leizhen (ThunderTown)
2020-10-14 7:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80cc7ea-9d1f-64a4-7c18-faf672bf8cf6@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).