From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EA6C433C1 for ; Wed, 31 Mar 2021 01:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D2C2619AB for ; Wed, 31 Mar 2021 01:54:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhCaBx1 (ORCPT ); Tue, 30 Mar 2021 21:53:27 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:15408 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233072AbhCaBxN (ORCPT ); Tue, 30 Mar 2021 21:53:13 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F98S15rdzzlWFn; Wed, 31 Mar 2021 09:51:29 +0800 (CST) Received: from [127.0.0.1] (10.174.179.202) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Wed, 31 Mar 2021 09:53:09 +0800 Subject: Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion To: Guenter Roeck , Wim Van Sebroeck , linux-watchdog , linux-kernel References: <20210327012028.1606-1-thunder.leizhen@huawei.com> <28b7616a-daa7-e944-8c0f-640eddaaebc8@roeck-us.net> From: "Leizhen (ThunderTown)" Message-ID: Date: Wed, 31 Mar 2021 09:53:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <28b7616a-daa7-e944-8c0f-640eddaaebc8@roeck-us.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.202] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 2021/3/28 3:50, Guenter Roeck wrote: > On 3/26/21 6:20 PM, Zhen Lei wrote: >> The header file is already included above and can be >> removed here. >> >> Signed-off-by: Zhen Lei > > Already submitted: > > https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/ > > In general, when removing duplicate or unnecessary header files, > please retain or improve alphabetic order. This patch makes it worse. Okay, thanks for the heads-up. I'll pay attention next time. > > Guenter > >> --- >> drivers/watchdog/dw_wdt.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c >> index 32d0e1781e63c4e..b1642e2d9175584 100644 >> --- a/drivers/watchdog/dw_wdt.c >> +++ b/drivers/watchdog/dw_wdt.c >> @@ -19,7 +19,6 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> > > > . >