From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Henning Schild <henning.schild@siemens.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org
Cc: Srikanth Krishnakar <skrishnakar@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Mark Gross <mgross@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs
Date: Thu, 1 Apr 2021 18:15:41 +0200 [thread overview]
Message-ID: <ffdfe9a9-ab17-18af-300e-062b79d132f3@metux.net> (raw)
In-Reply-To: <20210329174928.18816-4-henning.schild@siemens.com>
On 29.03.21 19:49, Henning Schild wrote:
Hi,
> This driver adds initial support for several devices from Siemens. It is
> based on a platform driver introduced in an earlier commit.
Where does the wdt actually come from ?
Is it in the SoC ? (which SoC exactly). SoC-builtin wdt is a pretty
usual case.
Or some external chip ?
The code smells a bit like two entirely different wdt's that just have
some similarities. If that's the case, I'd rather split it into two
separate drivers and let the parent driver (board file) instantiate
the correct one.
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2021-04-01 18:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 17:49 [PATCH v3 0/4] add device drivers for Siemens Industrial PCs Henning Schild
2021-03-29 17:49 ` [PATCH v3 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices Henning Schild
2021-11-26 12:39 ` Henning Schild
2021-03-29 17:49 ` [PATCH v3 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Henning Schild
2021-03-30 11:04 ` Andy Shevchenko
2021-03-30 11:58 ` Henning Schild
2021-03-30 12:15 ` Andy Shevchenko
2021-03-30 12:30 ` Henning Schild
2021-03-30 12:41 ` Andy Shevchenko
2021-03-30 15:23 ` Henning Schild
2021-03-31 15:40 ` Andy Shevchenko
2021-04-01 10:44 ` Henning Schild
2021-04-01 11:04 ` Andy Shevchenko
2021-04-12 11:56 ` Henning Schild
2021-05-05 14:58 ` Enrico Weigelt, metux IT consult
2021-04-12 15:15 ` Henning Schild
2021-11-26 13:28 ` Henning Schild
2021-11-26 14:02 ` Andy Shevchenko
2021-11-26 14:44 ` Henning Schild
2021-11-26 14:59 ` Andy Shevchenko
2021-11-26 19:54 ` Henning Schild
2021-11-25 17:11 ` Henning Schild
2021-03-29 17:49 ` [PATCH v3 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs Henning Schild
2021-04-01 16:15 ` Enrico Weigelt, metux IT consult [this message]
2021-04-06 14:52 ` Henning Schild
2021-04-07 8:53 ` Andy Shevchenko
2021-04-07 12:17 ` Guenter Roeck
2021-11-26 13:18 ` Henning Schild
2021-04-12 15:35 ` Henning Schild
2021-04-12 16:06 ` Guenter Roeck
2021-04-12 16:17 ` Henning Schild
2021-11-25 17:08 ` Henning Schild
2021-11-25 17:10 ` Henning Schild
2021-03-29 17:49 ` [PATCH v3 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs Henning Schild
2021-03-29 18:00 ` [PATCH v3 0/4] add device drivers for Siemens Industrial PCs Henning Schild
2021-04-07 11:36 ` Hans de Goede
2021-04-12 11:27 ` Henning Schild
2021-07-12 11:35 ` Henning Schild
2021-07-12 12:09 ` Andy Shevchenko
2021-07-12 16:11 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffdfe9a9-ab17-18af-300e-062b79d132f3@metux.net \
--to=lkml@metux.net \
--cc=andy.shevchenko@gmail.com \
--cc=gerd.haeussler.ext@siemens.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mgross@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=skrishnakar@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).