From: Kalle Valo <kvalo@codeaurora.org>
To: zhengbin <zhengbin13@huawei.com>
Cc: <arend.vanspriel@broadcom.com>, <franky.lin@broadcom.com>,
<kvalo@codeaurora.org>, <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<brcm80211-dev-list@cypress.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH -next] brcmfmac: remove set but not used variable 'mpnum','nsp','nmp'
Date: Wed, 20 Nov 2019 06:34:31 +0000 [thread overview]
Message-ID: <0101016e87850355-969ffdac-7a02-4d1e-af93-99e9c27109d6-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <1573888967-104078-1-git-send-email-zhengbin13@huawei.com> (zhengbin's message of "Sat, 16 Nov 2019 15:22:47 +0800")
zhengbin <zhengbin13@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_get_regaddr:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:790:5: warning: variable mpnum set but not used [-Wunused-but-set-variable]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_erom_scan:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:866:10: warning: variable nsp set but not used [-Wunused-but-set-variable]
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_erom_scan:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:866:5: warning: variable nmp set but not used [-Wunused-but-set-variable]
>
> They are introduced by commit 05491d2ccf20 ("brcm80211:
> move under broadcom vendor directory"), but never used,
> so remove them.
No they are not, that commit only moved the driver into a different
directory. I'll remove that sentence when I commit this.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-11-20 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 7:22 [PATCH -next] brcmfmac: remove set but not used variable 'mpnum','nsp','nmp' zhengbin
2019-11-20 6:34 ` Kalle Valo [this message]
2019-11-20 7:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101016e87850355-969ffdac-7a02-4d1e-af93-99e9c27109d6-000000@us-west-2.amazonses.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).