From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EF5C43215 for ; Wed, 20 Nov 2019 07:14:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE02E223CA for ; Wed, 20 Nov 2019 07:14:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="CYgYg1d2"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="HitXlYIB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727794AbfKTHOk (ORCPT ); Wed, 20 Nov 2019 02:14:40 -0500 Received: from a27-21.smtp-out.us-west-2.amazonses.com ([54.240.27.21]:39784 "EHLO a27-21.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727175AbfKTHOk (ORCPT ); Wed, 20 Nov 2019 02:14:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574234079; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=jTDnJbAD+OmeeNay72pKKr25SQyviuZ8HJ985/FTvTo=; b=CYgYg1d23p+M6KZP6LANHhnIAqafL9L7FQeUKAwPsYoFOA52/qChkuajKc8tARbE qBSaDT0g7Bc6p2UYwuBStTDd2xLLeWTad/AxEa/pXRJnntxs+iaQTEjB3D7FKO0lqcp jNAY57EiYFEGUrLxc/XuuYtEPDSZkdZ4faxrGD9Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574234079; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=jTDnJbAD+OmeeNay72pKKr25SQyviuZ8HJ985/FTvTo=; b=HitXlYIBzzUD+dI2jBlo9bjPl7kGbnb2C2bnqIjivKL3sbFJ3ddJx2xNEfZAI9vf dldpcK3WZbwnvWocKY9hieg2fggfwCd9IODFcnJ7si5mxH7Pio2mfckP5pTdOWp60VR 5L4b3d/ng6pMeoC9ZqsQyAP2sJLAeWL85qFVOh/M= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3834FC433A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: zhengbin Cc: , , , , , , , Subject: Re: [PATCH -next] brcmfmac: remove set but not used variable 'mpnum','nsp','nmp' References: <1573888967-104078-1-git-send-email-zhengbin13@huawei.com> Date: Wed, 20 Nov 2019 07:14:39 +0000 In-Reply-To: <1573888967-104078-1-git-send-email-zhengbin13@huawei.com> (zhengbin's message of "Sat, 16 Nov 2019 15:22:47 +0800") Message-ID: <0101016e87a9bfdf-2f0de3c7-8cd5-473e-b06b-3f6dab955c23-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2019.11.20-54.240.27.21 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org zhengbin writes: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_get_regaddr: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:790:5: warning: variable mpnum set but not used [-Wunused-but-set-variable] > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_erom_scan: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:866:10: warning: variable nsp set but not used [-Wunused-but-set-variable] > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c: In function brcmf_chip_dmp_erom_scan: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:866:5: warning: variable nmp set but not used [-Wunused-but-set-variable] > > They are introduced by commit 05491d2ccf20 ("brcm80211: > move under broadcom vendor directory"), but never used, > so remove them. > > Reported-by: Hulk Robot > Signed-off-by: zhengbin Applied, thanks. 7af496b9eb04 brcmfmac: remove set but not used variable 'mpnum','nsp','nmp' -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches