From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916C3C432C0 for ; Mon, 25 Nov 2019 17:56:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E9542086A for ; Mon, 25 Nov 2019 17:56:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Rw8lPNsi"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="R1A2l2zQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729238AbfKYR4E (ORCPT ); Mon, 25 Nov 2019 12:56:04 -0500 Received: from a27-11.smtp-out.us-west-2.amazonses.com ([54.240.27.11]:53792 "EHLO a27-11.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbfKYR4E (ORCPT ); Mon, 25 Nov 2019 12:56:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574704563; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=IrTYOqMqEOxm64GeOhR8U6dXnIpA0jutoDa4mZ0DD3k=; b=Rw8lPNsipmCaUViAQtvN0xjhd9Tica/Ps+4FAvItNFhKPy1+T60FDFKkDny+Cin5 BwdRDWH3NphC+KI96IBiBcNNra3R5EJo31mOtlJyDq4F8TgyDgZDMBppoK5cmOtVFr4 73QbtYLZ+YF5NYmIH3omYUjMoZMZMjRwSGVfiG/0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574704563; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=IrTYOqMqEOxm64GeOhR8U6dXnIpA0jutoDa4mZ0DD3k=; b=R1A2l2zQbt8Yay4Sc1/PrD+T1iWZc74BW6q8s4B91JS/8Pe6fQQEwaOMOd12Ay5k F83QwYvYWOXblkjis5lXTX0CT0J5/ZnrfCiGkZvpvJDIghpd6Pc+XrQ6usvN6mtmxSx TXEyhdZzLl6S9xZzXoVOYLt+AZm3HQ2ATf62yGvQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 33D0FC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Larry Finger Cc: Phong Tran , jakub.kicinski@netronome.com, davem@davemloft.net, luciano.coelho@intel.com, shahar.s.matityahu@intel.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, sara.sharon@intel.com, yhchuang@realtek.com, yuehaibing@huawei.com, pkshih@realtek.com, arend.vanspriel@broadcom.com, rafal@milecki.pl, franky.lin@broadcom.com, pieter-paul.giesberts@broadcom.com, p.figiel@camlintechnologies.com, Wright.Feng@cypress.com, keescook@chromium.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drivers: net: intel: Fix -Wcast-function-type References: <20191125150215.29263-1-tranmanphong@gmail.com> <20191125150215.29263-2-tranmanphong@gmail.com> <61fa4ef5-e4fc-c20c-9e20-158bcdf61cbb@lwfinger.net> Date: Mon, 25 Nov 2019 17:56:03 +0000 In-Reply-To: <61fa4ef5-e4fc-c20c-9e20-158bcdf61cbb@lwfinger.net> (Larry Finger's message of "Mon, 25 Nov 2019 11:30:47 -0600") Message-ID: <0101016ea3b4c45e-39ce3a65-7fba-4bf6-a788-ba579c1ea122-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2019.11.25-54.240.27.11 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Larry Finger writes: > On 11/25/19 9:02 AM, Phong Tran wrote: >> correct usage prototype of callback in tasklet_init(). >> Report by https://github.com/KSPP/linux/issues/20 >> >> Signed-off-by: Phong Tran >> --- >> drivers/net/wireless/intel/ipw2x00/ipw2100.c | 7 ++++--- >> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 5 +++-- >> drivers/net/wireless/intel/iwlegacy/3945-mac.c | 5 +++-- >> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 5 +++-- >> 4 files changed, 13 insertions(+), 9 deletions(-) > > This patch is "fixing" three different drivers and should be split > into at least two parts. To be consistent with previous practices, the > subject for the two should be "intel: ipw2100: ...." and "intel: > iwlegacy: ...." Actually, please drop even "intel:". So "ipw2x00: " and "iwlegacy: " is enough. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches