Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ath10k: move non-fatal warn logs to dbg level
@ 2019-11-25 13:10 Govind Singh
  2019-11-27 15:48 ` Kalle Valo
  0 siblings, 1 reply; 7+ messages in thread
From: Govind Singh @ 2019-11-25 13:10 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Govind Singh

During driver load below warn logs are printed in the console if
firmware doesn't support some optional HTC services, ex:pktlog.
It is likely some older fw version may not support PKTLOG HTC
service as legacy fw uses HTC DATA service  for pktlog.
Move this log to debug level to remove un-necessary warn message
on console.

htc.c:803:  ath10k_warn(ar, "unsupported HTC service id: %d\n",
htc.c:881:  ath10k_warn(ar, "unsupported HTC service id: %d\n",

Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/htc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c
index 28daed5981a1..367b762632d1 100644
--- a/drivers/net/wireless/ath/ath10k/htc.c
+++ b/drivers/net/wireless/ath/ath10k/htc.c
@@ -809,8 +809,8 @@ int ath10k_htc_connect_service(struct ath10k_htc *htc,
 						&ep->ul_pipe_id,
 						&ep->dl_pipe_id);
 	if (status) {
-		ath10k_warn(ar, "unsupported HTC service id: %d\n",
-			    ep->service_id);
+		ath10k_dbg(ar, ATH10K_DBG_BOOT, "unsupported HTC service id: %d\n",
+			   ep->service_id);
 		return status;
 	}
 
@@ -887,8 +887,8 @@ static bool ath10k_htc_pktlog_svc_supported(struct ath10k *ar)
 						&ul_pipe_id,
 						&dl_pipe_id);
 	if (status) {
-		ath10k_warn(ar, "unsupported HTC service id: %d\n",
-			    ATH10K_HTC_SVC_ID_HTT_LOG_MSG);
+		ath10k_dbg(ar, ATH10K_DBG_BOOT, "unsupported HTC pktlog service id: %d\n",
+			   ATH10K_HTC_SVC_ID_HTT_LOG_MSG);
 
 		return false;
 	}
-- 
2.22.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ath10k: move non-fatal warn logs to dbg level
  2019-11-25 13:10 [PATCH] ath10k: move non-fatal warn logs to dbg level Govind Singh
@ 2019-11-27 15:48 ` Kalle Valo
  0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2019-11-27 15:48 UTC (permalink / raw)
  To: Govind Singh; +Cc: ath10k, linux-wireless, Govind Singh

Govind Singh <govinds@codeaurora.org> wrote:

> During driver load below warn logs are printed in the console if
> firmware doesn't support some optional HTC services, ex:pktlog.
> It is likely some older fw version may not support PKTLOG HTC
> service as legacy fw uses HTC DATA service  for pktlog.
> Move this log to debug level to remove un-necessary warn message
> on console.
> 
> htc.c:803:  ath10k_warn(ar, "unsupported HTC service id: %d\n",
> htc.c:881:  ath10k_warn(ar, "unsupported HTC service id: %d\n",
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

ef39ac1b0d9f ath10k: move non-fatal warn logs to dbg level

-- 
https://patchwork.kernel.org/patch/11260371/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
  2018-12-20 16:40   ` Kalle Valo
@ 2018-12-20 17:43     ` Brian Norris
  0 siblings, 0 replies; 7+ messages in thread
From: Brian Norris @ 2018-12-20 17:43 UTC (permalink / raw)
  To: Kalle Valo; +Cc: govinds, linux-wireless, ath10k

On Thu, Dec 20, 2018 at 06:40:43PM +0200, Kalle Valo wrote:
> Brian Norris <briannorris@chromium.org> writes:
> > Alternatively, you could add these ignored commands to wmi-tlv.h, and
> > just ignore them specifically. That's better documentation, in case
> > new WMI events come along that *are* important to notice when we
> > ignore them. There are other recent examples of that sort of patch
> > being merged.
> 
> I have actually tried to do that (what Brian describes above) during the
> last years but the problem is that there are just so many different
> firmware branches that it's difficult to keep up in ath10k. So in the
> end these warnings just confused the users and they mistakenly thought
> this warning message is the cause of their problems. That's why I think
> it's best to remove this warning.

Thanks for the background. To be clear, I'm perfectly fine with this
patch too. I was mostly just volunteering an alternative, in case it
*was* your intention as maintainer to keep it this way.

Regards,
Brian

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
  2018-11-29  4:25 [PATCH] ath10k: Move " Govind Singh
  2018-11-30 20:59 ` Brian Norris
@ 2018-12-20 17:06 ` Kalle Valo
  1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2018-12-20 17:06 UTC (permalink / raw)
  To: Govind Singh; +Cc: ath10k, linux-wireless, Govind Singh

Govind Singh <govinds@codeaurora.org> wrote:

> During driver load below warn logs are printed in the console.
> Since driver may not implement all wmi events sent by fw and
> all of them are non-fatal, move this log to debug level to
> remove un-necessary warn message on console.
> 
> [  361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393
> [  361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
> 
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

bd085be6ba95 ath10k: move non-fatal warn logs to dbg level

-- 
https://patchwork.kernel.org/patch/10703901/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
  2018-11-30 20:59 ` Brian Norris
@ 2018-12-20 16:40   ` Kalle Valo
  2018-12-20 17:43     ` Brian Norris
  0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2018-12-20 16:40 UTC (permalink / raw)
  To: Brian Norris; +Cc: govinds, linux-wireless, ath10k

Brian Norris <briannorris@chromium.org> writes:

> On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@codeaurora.org> wrote:
>>
>> During driver load below warn logs are printed in the console.
>> Since driver may not implement all wmi events sent by fw and
>> all of them are non-fatal, move this log to debug level to
>> remove un-necessary warn message on console.
>>
>> [  361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393
>> [  361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>
> Alternatively, you could add these ignored commands to wmi-tlv.h, and
> just ignore them specifically. That's better documentation, in case
> new WMI events come along that *are* important to notice when we
> ignore them. There are other recent examples of that sort of patch
> being merged.

I have actually tried to do that (what Brian describes above) during the
last years but the problem is that there are just so many different
firmware branches that it's difficult to keep up in ath10k. So in the
end these warnings just confused the users and they mistakenly thought
this warning message is the cause of their problems. That's why I think
it's best to remove this warning.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ath10k: Move non-fatal warn logs to dbg level
  2018-11-29  4:25 [PATCH] ath10k: Move " Govind Singh
@ 2018-11-30 20:59 ` Brian Norris
  2018-12-20 16:40   ` Kalle Valo
  2018-12-20 17:06 ` Kalle Valo
  1 sibling, 1 reply; 7+ messages in thread
From: Brian Norris @ 2018-11-30 20:59 UTC (permalink / raw)
  To: govinds; +Cc: ath10k, linux-wireless

On Wed, Nov 28, 2018 at 8:25 PM Govind Singh <govinds@codeaurora.org> wrote:
>
> During driver load below warn logs are printed in the console.
> Since driver may not implement all wmi events sent by fw and
> all of them are non-fatal, move this log to debug level to
> remove un-necessary warn message on console.
>
> [  361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393
> [  361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>

Alternatively, you could add these ignored commands to wmi-tlv.h, and
just ignore them specifically. That's better documentation, in case
new WMI events come along that *are* important to notice when we
ignore them. There are other recent examples of that sort of patch
being merged.

Brian

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ath10k: Move non-fatal warn logs to dbg level
@ 2018-11-29  4:25 " Govind Singh
  2018-11-30 20:59 ` Brian Norris
  2018-12-20 17:06 ` Kalle Valo
  0 siblings, 2 replies; 7+ messages in thread
From: Govind Singh @ 2018-11-29  4:25 UTC (permalink / raw)
  To: ath10k; +Cc: linux-wireless, Govind Singh

During driver load below warn logs are printed in the console.
Since driver may not implement all wmi events sent by fw and
all of them are non-fatal, move this log to debug level to
remove un-necessary warn message on console.

[  361.887230] ath10k_snoc a000000.wifi: Unknown eventid: 16393
[  361.907037] ath10k_snoc a000000.wifi: Unknown eventid: 237569

Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index ad4114a88170..892bd8c30dd9 100644
--- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
+++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
@@ -621,7 +621,7 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k *ar, struct sk_buff *skb)
 		ath10k_wmi_event_mgmt_tx_compl(ar, skb);
 		break;
 	default:
-		ath10k_warn(ar, "Unknown eventid: %d\n", id);
+		ath10k_dbg(ar, ATH10K_DBG_WMI, "Unknown eventid: %d\n", id);
 		break;
 	}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 13:10 [PATCH] ath10k: move non-fatal warn logs to dbg level Govind Singh
2019-11-27 15:48 ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2018-11-29  4:25 [PATCH] ath10k: Move " Govind Singh
2018-11-30 20:59 ` Brian Norris
2018-12-20 16:40   ` Kalle Valo
2018-12-20 17:43     ` Brian Norris
2018-12-20 17:06 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git