Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ath9k: use iowrite32 over __raw_writel
@ 2019-11-24 14:40 Christian Lamparter
  2019-11-24 14:51 ` Kalle Valo
  2019-11-28  8:19 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Christian Lamparter @ 2019-11-24 14:40 UTC (permalink / raw)
  To: linux-wireless
  Cc: QCA ath9k Development, Kalle Valo, Hauke Mehrtens,
	Mathias Kresin, Martin Blumenstingl

This patch changes the ath9k_pci_owl_loader to use the
same iowrite32 memory accessor that ath9k_pci is using
to communicate with the PCI(e) chip.

This will fix endian issues that came up during testing
with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).

Fixes: 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c b/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c
index 956fa7828d0c..56d1a7764b9f 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c
+++ b/drivers/net/wireless/ath/ath9k/ath9k_pci_owl_loader.c
@@ -83,7 +83,7 @@ static int ath9k_pci_fixup(struct pci_dev *pdev, const u16 *cal_data,
 			val = swahb32(val);
 		}
 
-		__raw_writel(val, mem + reg);
+		iowrite32(val, mem + reg);
 		usleep_range(100, 120);
 	}
 
-- 
2.24.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ath9k: use iowrite32 over __raw_writel
  2019-11-24 14:40 [PATCH] ath9k: use iowrite32 over __raw_writel Christian Lamparter
@ 2019-11-24 14:51 ` Kalle Valo
  2019-11-28  8:19 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-11-24 14:51 UTC (permalink / raw)
  To: Christian Lamparter
  Cc: linux-wireless, QCA ath9k Development, Hauke Mehrtens,
	Mathias Kresin, Martin Blumenstingl

Christian Lamparter <chunkeey@gmail.com> writes:

> This patch changes the ath9k_pci_owl_loader to use the
> same iowrite32 memory accessor that ath9k_pci is using
> to communicate with the PCI(e) chip.
>
> This will fix endian issues that came up during testing
> with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).
>
> Fixes: 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>

I'll queue this to v5.5.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ath9k: use iowrite32 over __raw_writel
  2019-11-24 14:40 [PATCH] ath9k: use iowrite32 over __raw_writel Christian Lamparter
  2019-11-24 14:51 ` Kalle Valo
@ 2019-11-28  8:19 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-11-28  8:19 UTC (permalink / raw)
  To: Christian Lamparter
  Cc: linux-wireless, QCA ath9k Development, Hauke Mehrtens,
	Mathias Kresin, Martin Blumenstingl

Christian Lamparter <chunkeey@gmail.com> wrote:

> This patch changes the ath9k_pci_owl_loader to use the
> same iowrite32 memory accessor that ath9k_pci is using
> to communicate with the PCI(e) chip.
> 
> This will fix endian issues that came up during testing
> with loaned AVM Fritz!Box 7360 (Lantiq MIPS SoCs + AR9287).
> 
> Fixes: 5a4f2040fd07 ("ath9k: add loader for AR92XX (and older) pci(e)")
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>

Patch applied to wireless-drivers.git, thanks.

22d0d5ae7a08 ath9k: use iowrite32 over __raw_writel

-- 
https://patchwork.kernel.org/patch/11259213/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-24 14:40 [PATCH] ath9k: use iowrite32 over __raw_writel Christian Lamparter
2019-11-24 14:51 ` Kalle Valo
2019-11-28  8:19 ` Kalle Valo

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git