From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1DDC432C0 for ; Tue, 3 Dec 2019 09:08:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92CD82073C for ; Tue, 3 Dec 2019 09:08:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Yp1m60H7"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="Lf/ZCRCT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbfLCJI4 (ORCPT ); Tue, 3 Dec 2019 04:08:56 -0500 Received: from a27-10.smtp-out.us-west-2.amazonses.com ([54.240.27.10]:42222 "EHLO a27-10.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfLCJIz (ORCPT ); Tue, 3 Dec 2019 04:08:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1575364134; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=0vBFo/NUierkS/j/s2t2Px4zI2x8R1nbKIELE4PD5M0=; b=Yp1m60H7XKJ5s57pdyZvR06t0vmzmva6r+EO/1nwT/wHoJtVIc92XdgLF48D94vF CgDN6Qx5O+en0usKLuRJ2bfHt8+2wEVU5K8CGf2ztvZOdqKsKt/EhG6jEePXh7N5EMj EFTYW8A9Db6YYxHe4z2nMnKlgJEfFHHDluW58Q6A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1575364134; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=0vBFo/NUierkS/j/s2t2Px4zI2x8R1nbKIELE4PD5M0=; b=Lf/ZCRCTWTKRspSXzaXHZ7L8tJRzRI3D3VFUm1qRyHOCuXa2a6HUh//3LooNxqZZ 3UGwGg5g/R1GLZUsu0wsK8wOZlNVtjJn3Kho1aZB6o6YzrAb0pqC8HqEIRZjv92bO8E cdoj4xB02cJZJXjOGa3beKfCoDOR1xUGjynm8nZQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0C1E0C433A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Luciano Coelho Cc: Anders Kaseorg , Johannes Berg , Emmanuel Grumbach , Intel Linux Wireless , linux-wireless@vger.kernel.org Subject: Re: [PATCH v1.2] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" References: <0101016ecab326d1-88123857-cf37-47ab-b452-13658625364c-000000@us-west-2.amazonses.com> <7808e30fc20684cc0b47a5caf36a747e179c035c.camel@intel.com> Date: Tue, 3 Dec 2019 09:08:54 +0000 In-Reply-To: <7808e30fc20684cc0b47a5caf36a747e179c035c.camel@intel.com> (Luciano Coelho's message of "Tue, 03 Dec 2019 09:41:54 +0200") Message-ID: <0101016ecb05064e-722ee289-5d94-4275-a1f9-24dd0cfaeef7-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2019.12.03-54.240.27.10 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luciano Coelho writes: > On Tue, 2019-12-03 at 07:39 +0000, Kalle Valo wrote: >> Anders Kaseorg writes: >> >> > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99. >> > >> > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4 >> > attempted to fix the same bug (dead assignments to the local variable >> > cfg), but they did so in incompatible ways. When they were both merged, >> > independently of each other, the combination actually caused the bug to >> > reappear, leading to a firmware crash on boot for some cards. >> > >> > https://bugzilla.kernel.org/show_bug.cgi?id=205719 >> > >> > Signed-off-by: Anders Kaseorg >> > --- >> > [Nope it was more than just format=flowed damage. This one should be >> > better for real.] >> >> This is nitpicking but as a general comment I would prefer to use simple >> version numbering v2, v3 and so on. Trying to sort v1.2 in a script is >> awful. So calling this version v3 is very much preferred, it's not like >> we are running out of numbers :) > > Kalle, this patch makes sense. There was some merge damage because the > functions were moved around and the local variables' names have > changed, causing this mess. > > Can you please take this patch to v5.4 fixes when you're satisfied? Ok, I assigned this to myself and queue for v5.5. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches