Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: vthiagar@codeaurora.org
To: John Crispin <john@phrozen.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [RESEND 9/9] ath11k: optimize ath11k_hal_tx_status_parse
Date: Wed, 4 Dec 2019 06:02:12 +0000
Message-ID: <0101016ecf807633-d2b1f4c4-7fbe-4a82-a337-1add17ec852b-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <20191204053713.3064-10-john@phrozen.org>

On 2019-12-04 11:07, John Crispin wrote:
> Moving the function into dp_tx.c allows gcc to optimize the code better
> and also avoid chace invalidates and context switches.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  drivers/net/wireless/ath/ath11k/dp.h     |  2 +-
>  drivers/net/wireless/ath/ath11k/dp_tx.c  | 38 +++++++++++++++++++--
>  drivers/net/wireless/ath/ath11k/hal_tx.c | 43 ------------------------
>  drivers/net/wireless/ath/ath11k/hal_tx.h |  4 ---
>  4 files changed, 37 insertions(+), 50 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/dp.h
> b/drivers/net/wireless/ath/ath11k/dp.h
> index d4011f902930..2f0980f2c762 100644
> --- a/drivers/net/wireless/ath/ath11k/dp.h
> +++ b/drivers/net/wireless/ath/ath11k/dp.h
> @@ -57,7 +57,7 @@ struct dp_rxdma_ring {
>  	int bufs_max;
>  };
> 
> -#define ATH11K_TX_COMPL_NEXT(x)	((x + 1) % DP_TX_COMP_RING_SIZE)
> +#define ATH11K_TX_COMPL_NEXT(x)	(((x) + 1) % DP_TX_COMP_RING_SIZE)
> 
>  struct dp_tx_ring {
>  	u8 tcl_data_ring_id;
> diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c
> b/drivers/net/wireless/ath/ath11k/dp_tx.c
> index 5d6403cf99ab..828f8984235e 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
> @@ -423,6 +423,37 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
>  	rcu_read_unlock();
>  }
> 
> +static inline void ath11k_hal_tx_status_parse(struct ath11k_base *ab,
> +					      struct hal_wbm_release_ring *desc,
> +					      struct hal_tx_status *ts)

The function naming may need to be changed to be consistent with the 
other
functions in the file.

Vasanth

      reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  5:37 [RESEND 0/9] ath11k: resend pending patches John Crispin
2019-12-04  5:37 ` [RESEND 1/9] ath11k: add wmi helper for turning STA PS on/off John Crispin
2019-12-10 17:35   ` Kalle Valo
2019-12-04  5:37 ` [RESEND 2/9] ath11k: disable PS for STA interfaces by default upon bringup John Crispin
2019-12-04  5:37 ` [RESEND 3/9] ath11k: drop memset when setting up a tx cmd desc John Crispin
2019-12-04  5:37 ` [RESEND 4/9] ath11k: rename ath11k_wmi_base instances from wmi_sc to wmi_ab John Crispin
2019-12-04  5:37 ` [RESEND 5/9] ath11k: add WMI calls to manually add/del/pause/resume TWT dialogs John Crispin
2019-12-04  5:55   ` vthiagar
2019-12-04  5:37 ` [RESEND 6/9] ath11k: add debugfs for TWT debug calls John Crispin
2019-12-04  6:00   ` vthiagar
2019-12-04  5:37 ` [RESEND 7/9] ath11k: move some tx_status parsing to debugfs code John Crispin
2019-12-04  5:37 ` [RESEND 8/9] ath11k: optimise ath11k_dp_tx_completion_handler John Crispin
2019-12-04  5:37 ` [RESEND 9/9] ath11k: optimize ath11k_hal_tx_status_parse John Crispin
2019-12-04  6:02   ` vthiagar [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101016ecf807633-d2b1f4c4-7fbe-4a82-a337-1add17ec852b-000000@us-west-2.amazonses.com \
    --to=vthiagar@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git