From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <amitkarwar@gmail.com>, <ganapathi.bhat@nxp.com>,
<huxinming820@gmail.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <yuehaibing@huawei.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mwifiex: sdio: Fix -Wunused-const-variable warnings
Date: Mon, 7 Sep 2020 08:35:27 +0000 [thread overview]
Message-ID: <0101017467b4ac46-9af8a146-3a53-46e5-a96b-0d89ebfe3fe5-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <20200902141155.30144-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> These variables only used in sdio.c, move them to .c file
> can silence these warnings:
>
> In file included from drivers/net/wireless/marvell/mwifiex//main.h:59:0,
> from drivers/net/wireless/marvell/mwifiex//cfp.c:24:
> drivers/net/wireless/marvell/mwifiex//sdio.h:705:41: warning: ‘mwifiex_sdio_sd8801’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8801 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:689:41: warning: ‘mwifiex_sdio_sd8987’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8987 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:674:41: warning: ‘mwifiex_sdio_sd8887’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8887 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:658:41: warning: ‘mwifiex_sdio_sd8997’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8997 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:642:41: warning: ‘mwifiex_sdio_sd8977’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8977 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:627:41: warning: ‘mwifiex_sdio_sd8897’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8897 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:612:41: warning: ‘mwifiex_sdio_sd8797’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8797 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:597:41: warning: ‘mwifiex_sdio_sd8787’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8787 = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//sdio.h:582:41: warning: ‘mwifiex_sdio_sd8786’ defined but not used [-Wunused-const-variable=]
> static const struct mwifiex_sdio_device mwifiex_sdio_sd8786 = {
> ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
992a23702554 mwifiex: sdio: Fix -Wunused-const-variable warnings
--
https://patchwork.kernel.org/patch/11750823/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-09-07 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 14:11 [PATCH] mwifiex: sdio: Fix -Wunused-const-variable warnings YueHaibing
2020-09-07 8:35 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101017467b4ac46-9af8a146-3a53-46e5-a96b-0d89ebfe3fe5-000000@us-west-2.amazonses.com \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=davem@davemloft.net \
--cc=ganapathi.bhat@nxp.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).