linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Elwell <phil@raspberrypi.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Arend van Spriel <aspriel@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH] brcmfmac: firmware: Fix crash in brcm_alt_fw_path
Date: Wed, 19 Jan 2022 08:53:46 +0000	[thread overview]
Message-ID: <07dbaff1-bc12-d782-ed14-ef3f33d3c041@raspberrypi.com> (raw)
In-Reply-To: <87h7a0gt7f.fsf@kernel.org>

On 19/01/2022 06:01, Kalle Valo wrote:
> Phil Elwell <phil@raspberrypi.com> writes:
> 
>> The call to brcm_alt_fw_path in brcmf_fw_get_firmwares is not protected
>> by a check to the validity of the fwctx->req->board_type pointer. This
>> results in a crash in strlcat when, for example, the WLAN chip is found
>> in a USB dongle.
>>
>> Prevent the crash by adding the necessary check.
>>
>> See: https://github.com/raspberrypi/linux/issues/4833
>>
>> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware binaries")
>> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> 
> I think this should go to v5.17.

Is that an Ack? Are you asking me to submit the patch in a different way?

Phil

  reply	other threads:[~2022-01-19  8:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 15:45 [PATCH] brcmfmac: firmware: Fix crash in brcm_alt_fw_path Phil Elwell
2022-01-19  6:01 ` Kalle Valo
2022-01-19  8:53   ` Phil Elwell [this message]
2022-01-19 10:00     ` Kalle Valo
2022-01-19 15:48     ` Arend van Spriel
2022-01-27 12:08       ` Kalle Valo
2022-01-27 12:59         ` Arend van Spriel
2022-01-27 13:17           ` Kalle Valo
2022-01-27 14:30             ` Arend van Spriel
2022-01-27 15:36               ` Kalle Valo
2022-01-27 16:22                 ` Arend van Spriel
2022-01-28 14:07 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07dbaff1-bc12-d782-ed14-ef3f33d3c041@raspberrypi.com \
    --to=phil@raspberrypi.com \
    --cc=SHA-cyfmac-dev-list@infineon.com \
    --cc=aspriel@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).