[PATCH net] intersil/hostap: Fix outdated comment about dev->destructor

* [PATCH net] intersil/hostap: Fix outdated comment about dev->destructor
@ 2017-07-27 11:20 Stefano Brivio
  2017-08-03 10:08 ` [net] hostap: " Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2017-07-27 11:20 UTC (permalink / raw)
  To: netdev; +Cc: David S . Miller, Kalle Valo, Jouni Malinen, linux-wireless

After commit cf124db566e6 ("net: Fix inconsistent teardown and
release of private netdev state."), setting
'dev->needs_free_netdev' ensures device data is released, and
'dev->destructor' is not used anymore.

Fixes: cf124db566e6 ("net: Fix inconsistent teardown and release of private netdev state.")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
Despite checkpatch.pl warning against unnecessary changes, this
outdated comment might lead to confusion -- making this change
actually necessary, perhaps.

 drivers/net/wireless/intersil/hostap/hostap_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intersil/hostap/hostap_main.c b/drivers/net/wireless/intersil/hostap/hostap_main.c
index a3c066f90afc..012930d35434 100644
--- a/drivers/net/wireless/intersil/hostap/hostap_main.c
+++ b/drivers/net/wireless/intersil/hostap/hostap_main.c
@@ -125,8 +125,8 @@ void hostap_remove_interface(struct net_device *dev, int rtnl_locked,
 	else
 		unregister_netdev(dev);
 
-	/* dev->destructor = free_netdev() will free the device data, including
-	 * private data, when removing the device */
+	/* 'dev->needs_free_netdev = true' implies device data, including
+	 * private data, will be freed when the device is removed */
 }
 
 
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread