From: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To: Geliang Tang <geliangtang@163.com>,
"Berg, Johannes" <johannes.berg@intel.com>,
linuxwifi <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE()
Date: Wed, 25 Nov 2015 13:47:42 +0000 [thread overview]
Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB32E8FC5E8@hasmsx107.ger.corp.intel.com> (raw)
In-Reply-To: <7701ed112cc71a9a17ba5b3022166011a98d0dca.1448456395.git.geliangtang@163.com>
>
> WARN_ON_ONCE() takes a condition rather than a format string. This patch
> converted WARN_ON_ONCE() to WARN_ONCE() instead.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Already fixed. Thanks.
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
> b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
> index d1ad103..58d7bee 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
> @@ -1827,7 +1827,7 @@ static int rs_switch_to_column(struct iwl_mvm
> *mvm,
> rate->type = lq_sta->is_vht ? LQ_VHT_MIMO2 :
> LQ_HT_MIMO2;
> rate_mask = lq_sta->active_mimo2_rate;
> } else {
> - WARN_ON_ONCE("Bad column mode");
> + WARN_ONCE(1, "Bad column mode");
> }
>
> if (column->mode != RS_LEGACY) {
> --
> 2.5.0
>
prev parent reply other threads:[~2015-11-25 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com>
[not found] ` <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com>
[not found] ` <582529c23f77af64373f59fa92e29186df700d79.1448456395.git.geliangtang@163.com>
2015-11-25 13:12 ` [PATCH 4/7] iwlwifi: fix a problematic usage of WARN_ON_ONCE() Geliang Tang
2015-11-25 13:47 ` Grumbach, Emmanuel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0BA3FCBA62E2DC44AF3030971E174FB32E8FC5E8@hasmsx107.ger.corp.intel.com \
--to=emmanuel.grumbach@intel.com \
--cc=geliangtang@163.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).