From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA829C433E6 for ; Sat, 29 Aug 2020 18:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A40912075B for ; Sat, 29 Aug 2020 18:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728506AbgH2SXz (ORCPT ); Sat, 29 Aug 2020 14:23:55 -0400 Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:53888 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728265AbgH2SXx (ORCPT ); Sat, 29 Aug 2020 14:23:53 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 1D990182CED5B; Sat, 29 Aug 2020 18:23:51 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: humor54_0f10f2427080 X-Filterd-Recvd-Size: 6548 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Sat, 29 Aug 2020 18:23:44 +0000 (UTC) Message-ID: <0f837bfb394ac632241eaac3e349b2ba806bce09.camel@perches.com> Subject: sysfs output without newlines From: Joe Perches To: LKML , Denis Efremov , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kees Cook , "Gustavo A . R . Silva" , Julia Lawall , Alex Dewar Cc: York Sun , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Michal Simek , Boris Brezillon , Maxim Levitsky , Alex Dubov , Ulf Hansson , Tomas Winkler , Arnd Bergmann , Madalin Bucur , "David S. Miller" , Jakub Kicinski , Douglas Miller , Stanislav Yakovlev , Kalle Valo , Darren Hart , Andy Shevchenko , Kai =?ISO-8859-1?Q?M=E4kisara?= , "James E.J. Bottomley" , "Martin K. Petersen" , Mark Brown , Oliver Neukum , Pete Zaitcev , linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i3c@lists.infradead.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Date: Sat, 29 Aug 2020 11:23:43 -0700 Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org While doing an investigation for a possible treewide conversion of sysfs output using sprintf/snprintf/scnprintf, I discovered several instances of sysfs output without terminating newlines. It seems likely all of these should have newline terminations or have the \n\r termination changed to a single newline. Anyone have any objection to patches adding newlines to these in their original forms using sprintf/snprintf/scnprintf? A few of these might be false positives as "%s", string might already have string with a newline termination. +++ drivers/edac/fsl_ddr_edac.c + return sysfs_emit(data, "0x%08x", + return sysfs_emit(data, "0x%08x", + return sysfs_emit(data, "0x%08x", +++ drivers/edac/synopsys_edac.c + return sysfs_emit(data, "Data Poisoning: %s\n\r", + return sysfs_emit(buf, "1"); + return sysfs_emit(buf, "0"); + return sysfs_emit(buf, "1"); + return sysfs_emit(buf, "0"); + return sysfs_emit(buf, "0"); + return sysfs_emit(buf, "1"); + return sysfs_emit(buf, "0"); + return sysfs_emit(buf, "%u", !!(data->status & mask)); + return sysfs_emit(buf, "%u", data->tcrit2[index] * 1000); + return sysfs_emit(buf, "%d", + return sysfs_emit(buf, "%u", data->tcrit1[index] * 1000); + return sysfs_emit(buf, "%d", + return sysfs_emit(buf, "%d", data->toffset[index] * 500); +++ drivers/i3c/master.c + return sysfs_emit(buf, "i3c:dcr%02Xmanuf%04X", devinfo.dcr, + return sysfs_emit(buf, "i3c:dcr%02Xmanuf%04Xpart%04Xext%04X", + return sysfs_emit(buf, "%s", dd->boardversion); + return sysfs_emit(buf, "%s", dd->serial); + return sysfs_emit(buf, "%s", (char *)ib_qib_version); + return sysfs_emit(buf, "%s", dd->boardversion); + return sysfs_emit(buf, "%s", dd->lbus_info); + return sysfs_emit(buf, "ipac:f%02Xv%08Xd%08X", idev->id_format, +++ drivers/memstick/core/mspro_block.c + return sysfs_emit(buffer, "%s", (char *)s_attr->data); + return sysfs_emit(buf, "%s", + return sysfs_emit(buf, "%s", +++ drivers/misc/mei/bus.c + return sysfs_emit(buf, "%s", cldev->name); + return sysfs_emit(buf, "%pUl", uuid); + return sysfs_emit(buf, "%02X", version); + return sysfs_emit(buf, "mei:%s:%pUl:%02X:", + return sysfs_emit(buf, "%d", maxconn); + return sysfs_emit(buf, "%d", fixed); + return sysfs_emit(buf, "%d", vt); + return sysfs_emit(buf, "%u", maxlen); + return sysfs_emit(buf, "%s", mei_dev_state_str(dev_state)); +++ drivers/misc/tifm_core.c + return sysfs_emit(buf, "%x", sock->type); + return sysfs_emit(buf, "%s", + return sysfs_emit(buf, "%d", dev->net_count); +++ drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c + return sysfs_emit(buf, "%llx", + return sysfs_emit(buf, "none"); +++ drivers/net/ethernet/ibm/ehea/ehea_main.c + return sysfs_emit(buf, "%d", port->logical_port_id); +++ drivers/net/wireless/intel/ipw2x00/ipw2200.c + return sysfs_emit(buf, "%s", priv->prom_net_dev->name); + return sysfs_emit(buf, "0x%04X", + return sysfs_emit(buf, "%d", il->retry_rate); + return sysfs_emit(buf, "%pOF", np); + return sysfs_emit(buf, "pcmcia:m%04Xc%04Xf%02Xfn%02Xpfn%02X" +++ drivers/platform/x86/dell-smbios-base.c + return sysfs_emit(buf, "%08x", da_tokens[i].location); + return sysfs_emit(buf, "%08x", da_tokens[i].value); + return sysfs_emit(buf, "%08x", +++ drivers/scsi/st.c + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", + return sysfs_emit(buf, "%lld", +++ drivers/spi/spi-tle62x0.c + return sysfs_emit(buf, "%d", value); +++ drivers/usb/class/cdc-acm.c + return sysfs_emit(buf, "%d", acm->ctrl_caps); + return sysfs_emit(buf, "%d", acm->country_rel_date); +++ drivers/usb/class/usblp.c + return sysfs_emit(buf, "%s", usblp->device_id_string+2); + return sysfs_emit(buf, "usb:v%04Xp%04Xd%04Xdc%02Xdsc%02Xdp%02X" +++ drivers/usb/misc/cytherm.c + return sysfs_emit(buf, "%i", cytherm->brightness); + return sysfs_emit(buf, "%c%i.%i", sign ? '-' : '+', temp >> 1, + return sysfs_emit(buf, "1"); + return sysfs_emit(buf, "0"); + return sysfs_emit(buf, "%d", retval); + return sysfs_emit(buf, "%d", retval);