From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: "Vinita S. Maloo" <vmaloo@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add support to get BIP failure counters
Date: Thu, 17 Sep 2020 12:10:19 +0200 [thread overview]
Message-ID: <0fe215e191e90dfa843151a5ca1a43c2c2775121.camel@sipsolutions.net> (raw)
In-Reply-To: <20200731152702.GA15382@w1.fi>
On Fri, 2020-07-31 at 18:28 +0300, Jouni Malinen wrote:
> On Thu, Jul 30, 2020 at 01:41:04PM +0200, Johannes Berg wrote:
> > On Tue, 2020-06-30 at 11:56 +0530, Vinita S. Maloo wrote:
> > > Add support to get number of MIC errors, missing MME incidents and
> > > packet replay incidents observed while using IGTK/BIGTK keys when
> > > PMF and/or beacon protection features are enabled.
> >
> > I can imagine you need this for WFA tests, but why are the debugfs
> > counters not enough for that?
> >
> > I don't really see much functional reason (wpa_supplicant or so) to have
> > this, and thus why expose it in the nl80211 API?
>
> Do we have a policy or some kind of preference on how to address dot11
> statistics counters that can be handy at debugging real production use
> error cases?
Not really ...
> For this particular case, is there objection to adding
> support for fetching dot11RSNAStatsCMACReplays and
> dot11RSNAStatsCMACReplays counter values?
Do we really want to add them that way, or should they be at a key
level? To me it always felt a bit like they should be per key, and we
expose some counters that way in debugfs I believe.
OTOH, you can argue that they are MIBs today, so they should be exposed
as such? And maybe firmware doesn't support per-key data, etc.
So I don't really have a strong opinion on it, but I feel that we have a
hodge-podge of things in this area, doing one thing with debugfs,
another thing with nl80211, etc.
johannes
prev parent reply other threads:[~2020-09-17 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:26 [PATCH] nl80211: Add support to get BIP failure counters Vinita S. Maloo
2020-07-30 11:41 ` Johannes Berg
2020-07-31 15:28 ` Jouni Malinen
2020-09-17 10:10 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe215e191e90dfa843151a5ca1a43c2c2775121.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=vmaloo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).