linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net,
	Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH 04/14] iwlwifi: Thermal Throttling Management - part 2
Date: Tue, 28 Jul 2009 00:29:20 +0200	[thread overview]
Message-ID: <1248733760.7015.0.camel@johannes.local> (raw)
In-Reply-To: <1248459194-10239-5-git-send-email-reinette.chatre@intel.com>

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Fri, 2009-07-24 at 11:13 -0700, Reinette Chatre wrote:

>  /**
> + * struct iwl_tt_restriction - Thermal Throttling restriction table used
> + *		by advance thermal throttling management
> + *		based on the current thermal throttling state, determine
> + *		number of tx/rx streams; and the status of HT operation
> + * @tx_stream: number of tx stream allowed
> + * @is_ht: ht enable/disable
> + * @rx_stream: number of rx stream allowed
> + */

This kernel-doc, and some others, are really botched btw -- the bit
after 'struct foo - ' really needs to be a single line only, you can put
longer descriptions after the parameters.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-07-27 22:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 18:12 [PATCH 0/14] iwlwifi driver updates 07/24/2009 Reinette Chatre
2009-07-24 18:13 ` [PATCH 01/14] iwlwifi: revert to active table when rate is not valid Reinette Chatre
2009-07-24 18:13 ` [PATCH 02/14] iwlwifi: critical temperature enter/exit condition Reinette Chatre
2009-07-24 18:13 ` [PATCH 03/14] iwlwifi: Thermal Throttling Management - Part 1 Reinette Chatre
2009-07-24 18:13 ` [PATCH 04/14] iwlwifi: Thermal Throttling Management - part 2 Reinette Chatre
2009-07-27 22:29   ` Johannes Berg [this message]
2009-07-27 22:46     ` reinette chatre
2009-07-28  7:33       ` Johannes Berg
2009-07-28  7:47         ` reinette chatre
2009-07-24 18:13 ` [PATCH 05/14] iwlwifi: Thermal Throttling debugfs function Reinette Chatre
2009-07-24 18:13 ` [PATCH 06/14] iwlwifi: fix up command sending Reinette Chatre
2009-07-24 18:13 ` [PATCH 07/14] iwlwifi: remove command callback return value Reinette Chatre
2009-07-24 18:13 ` [PATCH 08/14] iwlwifi: fix TX queue race Reinette Chatre
2009-07-24 18:13 ` [PATCH 09/14] iwlwifi: print packet contents in error case Reinette Chatre
2009-07-24 18:13 ` [PATCH 10/14] iwlwifi: Name fix for MPDU density for TX aggregation Reinette Chatre
2009-07-24 18:13 ` [PATCH 11/14] iwlwifi: fix LED config option Reinette Chatre
2009-07-24 18:13 ` [PATCH 12/14] iwlwifi: debugFs to enable/disable 40MHz channel support Reinette Chatre
2009-07-24 21:40   ` Gábor Stefanik
2009-07-25 17:24     ` Guy, Wey-Yi W
2009-07-24 18:13 ` [PATCH 13/14] iwlagn: fix null pointer access during ucode load on 1000 Reinette Chatre
2009-07-24 18:13 ` [PATCH 14/14] iwlagn: fix sparse warning when compiling without debug Reinette Chatre
2009-07-24 18:13 ` [PATCH v2.6.31] iwlwifi: fix TX queue race Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248733760.7015.0.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).