From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/3] cfg80211: use goto out on 11d reg hint failure
Date: Thu, 30 Jul 2009 19:27:50 +0200 [thread overview]
Message-ID: <1248974870.23496.0.camel@johannes.local> (raw)
In-Reply-To: <1248974386-8168-2-git-send-email-lrodriguez@atheros.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Thu, 2009-07-30 at 10:19 -0700, Luis R. Rodriguez wrote:
> This does not change functionality.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> net/wireless/reg.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
> index fb40428..2d1d183 100644
> --- a/net/wireless/reg.c
> +++ b/net/wireless/reg.c
> @@ -1774,10 +1774,8 @@ void regulatory_hint_11d(struct wiphy *wiphy,
>
> mutex_lock(&cfg80211_mutex);
>
> - if (unlikely(!last_request)) {
> - mutex_unlock(&cfg80211_mutex);
> - return;
> - }
> + if (unlikely(!last_request))
> + goto out;
>
> /* IE len must be evenly divisible by 2 */
> if (country_ie_len & 0x01)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-07-30 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 17:19 [PATCH v2 0/3] wireless: fix 11d lockdep and move 11d hint to cfg80211 Luis R. Rodriguez
2009-07-30 17:19 ` [PATCH v2 1/3] cfg80211: use goto out on 11d reg hint failure Luis R. Rodriguez
2009-07-30 17:27 ` Johannes Berg [this message]
2009-07-30 17:19 ` [PATCH v2 2/3] cfg80211: decouple regulatory variables from cfg80211_mutex Luis R. Rodriguez
2009-07-30 17:28 ` Johannes Berg
2009-07-30 17:19 ` [PATCH v2 3/3] cfg80211: enable country IE support to all cfg80211 drivers Luis R. Rodriguez
2009-07-30 17:28 ` Johannes Berg
2009-07-30 20:59 ` [PATCH v2 0/3] wireless: fix 11d lockdep and move 11d hint to cfg80211 Luis R. Rodriguez
2009-07-30 17:22 Luis R. Rodriguez
2009-07-30 17:22 ` [PATCH v2 1/3] cfg80211: use goto out on 11d reg hint failure Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248974870.23496.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).