Re: [wireless] rt2870sta BUGs on shutdown, 2.6.30.2->git.today+git.wireless.today

From: Dan Williams <dcbw@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Ivo van Doorn <ivdoorn@gmail.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Luis Correia <luis.f.correia@gmail.com>,
	Mike Galbraith <efault@gmx.de>,
	linux-wireless@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [wireless] rt2870sta BUGs on shutdown, 2.6.30.2->git.today+git.wireless.today
Date: Thu, 30 Jul 2009 14:04:43 -0400	[thread overview]
Message-ID: <1248977083.24886.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20090730172657.GA8266@kroah.com>

On Thu, 2009-07-30 at 10:26 -0700, Greg KH wrote:
> On Thu, Jul 30, 2009 at 07:11:02PM +0200, Johannes Berg wrote:
> > On Thu, 2009-07-30 at 18:52 +0200, Ivo van Doorn wrote:
> > 
> > > [some text expressing his frustration]
> > 
> > This is exactly why I was against staging all the time. Now suddenly
> > "The Crap" seems like a viable alternative. WAKE UP PEOPLE. The code is
> > not useful. Just look at the code that Mike pasted into his email. That
> > alone should be enough to send cold shivers down your spine!
> 
> Hm, "useful" is in the eye of the beholder.
> 
> There is no driver in the mainline kernel tree for this device, so a
> "normal" user has no chance of getting it working, right?  That's why
> -staging is working, there is a semi-working driver, and most
> importantly, people willing to help out getting it working better.
> 
> The combination of the two is what works here.
> 
> So please, I understand your frustration on a lack of people helping out
> with out-of-tree wireless drivers that don't quite work properly, but
> please, that has NOTHING to do with the staging drivers.
> 
> Meanwhile, I'm off on the driver-devel list helping Mike fix this
> problem, which seems simple enough to solve...

Except that the energy you're now investing in fixing this could have
gone into rt2x00, and we would come out ahead in the end.  Instead, the
energy is sapped away by something that will *never* be mainlined.

Dan

> > What staging has achieved here is giving the crap vendor code a
> > blessing, receiving it welcomingly and forgivingly instead of saying
> > "well screw you, go ahead and ship this to your users but don't ever say
> > you support Linux well" ... now even some hackers and just just "dumb
> > users" think that the crap in staging could possibly at some point
> > become useful code!
> 
> Odd, I don't seem to be giving anyone such a "blessing", you are reading
> way too much into this.  The fact is this vendor does code drops and
> runs away all the time, despite the code being in the staging tree or
> not.  Without it in the staging tree users would be worse off, not
> better, there is no pressure able to be applied here at all, so please
> stop thinking that.
> 
> > It won't. EVER. No matter _how_ much you clean it up, it will NEVER fit
> > into the code scheme that everything else wireless has adopted.
> 
> never say never, it will happen, just give us time :)
> 
> In the meanwhile, people like Bart and others are doing real work on
> getting the staging code into shape and working for real users.  Who are
> you to tell them to not do such work?
> 
> thanks,
> 
> greg "i love crap" k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html