From: Marcel Holtmann <marcel@holtmann.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Reinette Chatre <reinette.chatre@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: use beacons for connection monitoring
Date: Fri, 31 Jul 2009 02:41:13 -0700 [thread overview]
Message-ID: <1249033273.23662.7.camel@localhost.localdomain> (raw)
In-Reply-To: <1249027460.2609.2.camel@maxim-laptop>
Hi Maxim,
> > > Fix it then. Offer an implementation of your superior solution.
> >
> > I just don't think that this patch is a solution because it means that
> > we'll be connected to the AP forever, without knowing anything is wrong,
> > if the AP can reach us but we can't reach the AP (maybe because we have
> > a good Intel card with great sensitivity).
> >
> > Sure -- it's possible to factor in transmit status reports (but remember
> > that not all hardware gives those reliably) or do things on a different
> > schedule etc. But as long as nobody wants to really improve things I
> > don't see why we should take the regression and _remove_ the current
> > behaviour.
>
> It is ok to send probes every minute or so, but not each second, and
> probes must be retried.
>
> Because of these probes, wireless literally reconnects every 5 seconds,
> here, and I am 10 meters from the AP.
even with Reinette's patch, I am seeing this:
[18594.423855] wlan0: cancelling probereq poll due to a received beacon
[18629.544841] No probe response from AP 00:1c:f0:xx:xx:xx after 200ms, disconnecting.
So that is with the patch, being 1m away from the AP, in the 18th floor
of a building and with only another 10 APs around me.
The Bluetooth world calls this link supervision timeout and the default
value for that timeout is 30 seconds. I think it is the best to make
this value configurable and increase it to at least 30 seconds by
default. Within Bluetooth you can change it and runtime.
Johannes, I don't care how good or bad some hardware is. How sensitive
or not. This is a clear regression and you are overdoing it here with
only waiting for 200ms.
Regards
Marcel
next prev parent reply other threads:[~2009-07-31 9:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 21:32 [PATCH] mac80211: use beacons for connection monitoring Reinette Chatre
2009-07-29 21:39 ` Ben Greear
2009-07-30 10:30 ` Johannes Berg
2009-07-30 14:41 ` Ben Greear
2009-07-30 17:45 ` reinette chatre
2009-07-30 19:47 ` Johannes Berg
2009-07-29 21:45 ` Johannes Berg
2009-07-29 21:50 ` reinette chatre
2009-07-30 5:24 ` Maxim Levitsky
2009-07-29 22:10 ` Ben Greear
2009-07-30 10:28 ` Johannes Berg
2009-07-30 2:39 ` Marcel Holtmann
2009-07-30 9:36 ` Helmut Schaa
2009-07-30 9:54 ` Johannes Berg
2009-07-31 7:08 ` Maxim Levitsky
2009-07-31 7:43 ` Johannes Berg
2009-07-31 7:58 ` Johannes Berg
2009-07-31 8:04 ` Maxim Levitsky
2009-07-31 9:41 ` Marcel Holtmann [this message]
2009-07-31 13:19 ` Maxim Levitsky
2009-07-31 13:39 ` Johannes Berg
2009-07-31 13:56 ` Maxim Levitsky
2009-07-31 14:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249033273.23662.7.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=maximlevitsky@gmail.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).