linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
	jirislaby@gmail.com, linux-wireless@vger.kernel.org,
	ath5k-devel@lists.ath5k.org, linville@tuxdriver.com
Subject: Re: [ath5k-devel] [PATCH 4/4] ath5k: Use SWI to trigger calibration
Date: Fri, 31 Jul 2009 15:09:45 -0400	[thread overview]
Message-ID: <1249067385.20276.16.camel@mj> (raw)
In-Reply-To: <40f31dec0907311125o1654bd23jee861ba8bea57611@mail.gmail.com>

On Fri, 2009-07-31 at 21:25 +0300, Nick Kossifidis wrote:

> a) We don't need a timer for this, there is no need for accuracy
>     even with round_jiffies i think this is a waste of resources.
>     Also we don't need to run calibration if we are idle (no interrupts).

It doesn't sound right to me.

Can it be that the device gets so miscalibrated during the silence that
it won't be able to receive signal once it's there?  Say, the device is
set to channel 1 but it actually listens to channel 3, and there are
some weak beacons on channel 1.

And then there is an issue of the frequency straying outside the
permitted spectrum.  Perhaps the transmission will trigger interrupts
and thus recalibration, but in case of scanning, the first probe
requests could be on wrong frequencies.

I would probably leave the timer and allow the interrupts make the
delays shorter.

-- 
Regards,
Pavel Roskin

  parent reply	other threads:[~2009-07-31 19:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 18:10 [PATCH 4/4] ath5k: Use SWI to trigger calibration Nick Kossifidis
2009-07-31 18:15 ` Luis R. Rodriguez
2009-07-31 18:25   ` [ath5k-devel] " Nick Kossifidis
2009-07-31 18:48     ` Luis R. Rodriguez
2009-07-31 19:09     ` Pavel Roskin [this message]
2009-07-31 19:35       ` Nick Kossifidis
2009-07-31 19:43         ` Pavel Roskin
2009-07-31 19:11     ` Bob Copeland
2009-07-31 19:52       ` Nick Kossifidis
2009-08-01 13:22         ` Bob Copeland
2009-08-01 13:31           ` Nick Kossifidis
2009-08-02 16:14             ` Bob Copeland
2009-07-31 18:34 ` Nick Kossifidis
2009-08-01  5:46 ` Nick Kossifidis
2009-08-01  8:19   ` Jiri Slaby
2009-08-01  8:21     ` Johannes Berg
2009-08-01  8:24       ` Jiri Slaby
2009-08-01  8:28         ` Johannes Berg
2009-08-01  8:31           ` [ath5k-devel] " Nick Kossifidis
2009-08-01  8:35             ` Jiri Slaby
2009-08-03 17:54           ` Nick Kossifidis
2009-08-07 14:55             ` John W. Linville
2009-08-07 19:50               ` Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249067385.20276.16.camel@mj \
    --to=proski@gnu.org \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    --cc=mickflemm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).