From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, me@bobcopeland.com, mcgrof@gmail.com,
nbd@openwrt.org, proski@gnu.org
Subject: Re: [PATCH 4/4] ath5k: Use SWI to trigger calibration
Date: Sat, 01 Aug 2009 10:28:36 +0200 [thread overview]
Message-ID: <1249115316.2007.0.camel@johannes.local> (raw)
In-Reply-To: <4A73FBBD.3070507@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
On Sat, 2009-08-01 at 10:24 +0200, Jiri Slaby wrote:
> On 08/01/2009 10:21 AM, Johannes Berg wrote:
> > Actually, jiffies are unsigned long
>
> Yeah, this is what I meant. I agree I messed it up when I didn't write
> the unsigned explicitly. It might have been confusing, thanks for
> pointing out.
And, in addition to what you said, the code shouldn't divide jiffies, it
should multiply the timeout, add it to the start time, and then use
time_is_after_jiffies() or so.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-08-01 8:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 18:10 [PATCH 4/4] ath5k: Use SWI to trigger calibration Nick Kossifidis
2009-07-31 18:15 ` Luis R. Rodriguez
2009-07-31 18:25 ` [ath5k-devel] " Nick Kossifidis
2009-07-31 18:48 ` Luis R. Rodriguez
2009-07-31 19:09 ` Pavel Roskin
2009-07-31 19:35 ` Nick Kossifidis
2009-07-31 19:43 ` Pavel Roskin
2009-07-31 19:11 ` Bob Copeland
2009-07-31 19:52 ` Nick Kossifidis
2009-08-01 13:22 ` Bob Copeland
2009-08-01 13:31 ` Nick Kossifidis
2009-08-02 16:14 ` Bob Copeland
2009-07-31 18:34 ` Nick Kossifidis
2009-08-01 5:46 ` Nick Kossifidis
2009-08-01 8:19 ` Jiri Slaby
2009-08-01 8:21 ` Johannes Berg
2009-08-01 8:24 ` Jiri Slaby
2009-08-01 8:28 ` Johannes Berg [this message]
2009-08-01 8:31 ` [ath5k-devel] " Nick Kossifidis
2009-08-01 8:35 ` Jiri Slaby
2009-08-03 17:54 ` Nick Kossifidis
2009-08-07 14:55 ` John W. Linville
2009-08-07 19:50 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249115316.2007.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=nbd@openwrt.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).