From: Johannes Berg <johannes@sipsolutions.net>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: fix attrtype and value for NL80211_ATTR_SUPPORTED_COMMANDS
Date: Wed, 05 Aug 2009 17:41:41 +0200 [thread overview]
Message-ID: <1249486901.6902.6.camel@johannes.local> (raw)
In-Reply-To: <1249464510-21539-1-git-send-email-yi.zhu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Wed, 2009-08-05 at 17:28 +0800, Zhu Yi wrote:
> The patch fixes the misuse between attrtype and value for the
> CMD list nested in NL80211_ATTR_SUPPORTED_COMMANDS attribute.
No? It was this way intentionally.
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -520,7 +520,7 @@ static int nl80211_send_wiphy(struct sk_buff *msg, u32 pid, u32 seq, int flags,
> do { \
> if (dev->ops->op) { \
> i++; \
> - NLA_PUT_U32(msg, i, NL80211_CMD_ ## n); \
> + NLA_PUT_U32(msg, NL80211_CMD_ ## n, i); \
This is an array, the index doesn't matter, and the value is the
supported command. You parse it with nla_for_each_nested()
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-08-05 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-05 9:28 [PATCH] nl80211: fix attrtype and value for NL80211_ATTR_SUPPORTED_COMMANDS Zhu Yi
2009-08-05 15:41 ` Johannes Berg [this message]
2009-08-06 1:46 ` Zhu Yi
2009-08-06 7:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249486901.6902.6.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).