From: Javier Cardona <javier@cozybit.com>
To: linux-wireless@vger.kernel.org
Cc: Andrey Yurovsky <andrey@cozybit.com>,
Javier Cardona <javier@cozybit.com>,
johannes@sipsolutions.net, linville@tuxdriver.com,
devel@lists.open80211s.org
Subject: [PATCH] mac80211: Use correct sign for mesh active path refresh.
Date: Fri, 7 Aug 2009 20:31:48 -0700 [thread overview]
Message-ID: <1249702314-32504-3-git-send-email-javier@cozybit.com> (raw)
In-Reply-To: <1249702314-32504-2-git-send-email-javier@cozybit.com>
From: Andrey Yurovsky <andrey@cozybit.com>
On locally originated traffic, we refresh active paths after a timeout. The
decision to do this was using the wrong sign and therefore the refresh timer
was triggered for every frame.
Signed-off-by: Andrey Yurovsky <andrey@cozybit.com>
Signed-off-by: Javier Cardona <javier@cozybit.com>
---
net/mac80211/mesh_hwmp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index b54c21c..1cd1e72 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -791,7 +791,7 @@ int mesh_nexthop_lookup(struct sk_buff *skb,
}
if (mpath->flags & MESH_PATH_ACTIVE) {
- if (time_after(jiffies, mpath->exp_time -
+ if (time_after(jiffies, mpath->exp_time +
msecs_to_jiffies(sdata->u.mesh.mshcfg.path_refresh_time))
&& !memcmp(sdata->dev->dev_addr, hdr->addr4,
ETH_ALEN)
--
1.5.4.3
next prev parent reply other threads:[~2009-08-08 3:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 3:31 Mesh fixes and improvements Javier Cardona
2009-08-08 3:31 ` [PATCH] mac80211: Improve dequeing from mpath frame queue Javier Cardona
2009-08-08 3:31 ` Javier Cardona [this message]
2009-08-08 3:31 ` [PATCH] mac80211: Simulate transmission losses on plinks to aid in testing mesh metrics Javier Cardona
2009-08-08 3:31 ` [PATCH] mac80211: Use 3-address format for mesh broadcast frames Javier Cardona
2009-08-08 3:31 ` [PATCH] mac80211: Update the station failed frames average when minstrel is used Javier Cardona
2009-08-08 3:31 ` [PATCH] mac80211: Early detection of broken mesh paths when using minstrel Javier Cardona
2009-08-08 3:31 ` [PATCH] mac80211: Assign a default mesh beaconing interval Javier Cardona
2009-08-08 3:31 ` [PATCH] mac80211: Moved mpath and mpp growth to mesh workqueue Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249702314-32504-3-git-send-email-javier@cozybit.com \
--to=javier@cozybit.com \
--cc=andrey@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).