linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: linux-wireless@vger.kernel.org, andrey@cozybit.com,
	linville@tuxdriver.com, devel@lists.open80211s.org
Subject: Re: Mesh fixes and improvements
Date: Sat, 08 Aug 2009 11:09:02 +0200	[thread overview]
Message-ID: <1249722543.31670.19.camel@johannes.local> (raw)
In-Reply-To: <1249702711-32737-1-git-send-email-javier@cozybit.com>

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

On Fri, 2009-08-07 at 20:38 -0700, Javier Cardona wrote:
> [Resent with proper patch numbering...]
> 
> This series includes some fixes, testing aids and improvements to the mesh
> stack.  It is important to note that the patch
> "Use-3-address-format-for-mesh-broadcast-frames" breaks compatibility with
> previous versions.  This is unavoidable and will keep happening as new versions
> of the 802.11s drafts are produced.

That's ok, can you update the Kconfig though to indicate which draft
it's compatible with? It says 1.08 right now.

> Also, I'm not sure if "Simulate-transmission-losses-on-plinks-to-..." should be
> merged upstream, but we find it really useful to test mesh configurations.
> Please comment if you have different opinions on its adequacy or
> implementation.

As I said elsewhere in this thread I don't think that should be in,
especially not, as Kalle points out, using nl80211.

All the other patches look ok on a cursory look, I just wish you'd write
more detailed changelog entries.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  parent reply	other threads:[~2009-08-08  9:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-08  3:38 Mesh fixes and improvements Javier Cardona
2009-08-08  3:38 ` [PATCH 1/8] mac80211: Improve dequeing from mpath frame queue Javier Cardona
2009-08-08  3:38   ` [PATCH 2/8] mac80211: Use correct sign for mesh active path refresh Javier Cardona
2009-08-08  3:38     ` [PATCH 3/8] mac80211: Simulate transmission losses on plinks to aid in testing mesh metrics Javier Cardona
2009-08-08  3:38       ` [PATCH 4/8] mac80211: Use 3-address format for mesh broadcast frames Javier Cardona
2009-08-08  3:38         ` [PATCH 5/8] mac80211: Update the station failed frames average when minstrel is used Javier Cardona
2009-08-08  3:38           ` [PATCH 6/8] mac80211: Early detection of broken mesh paths when using minstrel Javier Cardona
2009-08-08  3:38             ` [PATCH 7/8] mac80211: Assign a default mesh beaconing interval Javier Cardona
2009-08-08  3:38               ` [PATCH 8/8] mac80211: Moved mpath and mpp growth to mesh workqueue Javier Cardona
2009-08-08  8:09       ` [PATCH 3/8] mac80211: Simulate transmission losses on plinks to aid in testing mesh metrics Kalle Valo
2009-08-08  8:46         ` Johannes Berg
2009-08-08  9:09 ` Johannes Berg [this message]
2009-08-09  4:55   ` Mesh fixes and improvements Javier Cardona
2009-08-10 17:52     ` John W. Linville
2009-08-10 19:15       ` Mesh fixes and improvements [v2] Javier Cardona
2009-08-10 19:15         ` [PATCH 1/7] mac80211: Improve dequeing from mpath frame queue Javier Cardona
2009-08-10 19:15           ` [PATCH 2/7] mac80211: Use correct sign for mesh active path refresh Javier Cardona
2009-08-10 19:15             ` [PATCH 3/7] mac80211: Use 3-address format for mesh broadcast frames Javier Cardona
2009-08-10 19:15               ` [PATCH 4/7] mac80211: Update the station failed frames average when minstrel is used Javier Cardona
2009-08-10 19:15                 ` [PATCH 5/7] mac80211: Early detection of broken mesh paths when using minstrel Javier Cardona
2009-08-10 19:15                   ` [PATCH 6/7] mac80211: Assign a default mesh beaconing interval Javier Cardona
2009-08-10 19:15                     ` [PATCH 7/7] mac80211: Move mpath and mpp growth to mesh workqueue Javier Cardona
  -- strict thread matches above, loose matches on Subject: below --
2009-08-08  3:31 Mesh fixes and improvements Javier Cardona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249722543.31670.19.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=andrey@cozybit.com \
    --cc=devel@lists.open80211s.org \
    --cc=javier@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).