* [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211()
@ 2009-08-12 11:07 Kalle Valo
2009-08-12 15:37 ` reinette chatre
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2009-08-12 11:07 UTC (permalink / raw)
To: linville; +Cc: reinette.chatre, linux-wireless
Commit "iwlwifi: Traffic type and counter for debugFs" broke iwl3945 in
a case when CONFIG_IWLWIFI_LEDS is disabled:
drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
Fix it by removing the ifdef check for hdr variable.
Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
---
drivers/net/wireless/iwlwifi/iwl-3945.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index ae7f163..ba5ef83 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -544,9 +544,7 @@ static void iwl3945_pass_packet_to_mac80211(struct iwl_priv *priv,
struct ieee80211_rx_status *stats)
{
struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
-#ifdef CONFIG_IWLWIFI_LEDS
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)IWL_RX_DATA(pkt);
-#endif
struct iwl3945_rx_frame_hdr *rx_hdr = IWL_RX_HDR(pkt);
struct iwl3945_rx_frame_end *rx_end = IWL_RX_END(pkt);
short len = le16_to_cpu(rx_hdr->len);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211()
2009-08-12 11:07 [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211() Kalle Valo
@ 2009-08-12 15:37 ` reinette chatre
2009-08-12 18:27 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: reinette chatre @ 2009-08-12 15:37 UTC (permalink / raw)
To: Kalle Valo; +Cc: linville, linux-wireless
On Wed, 2009-08-12 at 04:07 -0700, Kalle Valo wrote:
> Commit "iwlwifi: Traffic type and counter for debugFs" broke iwl3945 in
> a case when CONFIG_IWLWIFI_LEDS is disabled:
>
> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
>
> Fix it by removing the ifdef check for hdr variable.
>
> Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
> ---
>
> drivers/net/wireless/iwlwifi/iwl-3945.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index ae7f163..ba5ef83 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -544,9 +544,7 @@ static void iwl3945_pass_packet_to_mac80211(struct iwl_priv *priv,
> struct ieee80211_rx_status *stats)
> {
> struct iwl_rx_packet *pkt = (struct iwl_rx_packet *)rxb->skb->data;
> -#ifdef CONFIG_IWLWIFI_LEDS
> struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)IWL_RX_DATA(pkt);
> -#endif
> struct iwl3945_rx_frame_hdr *rx_hdr = IWL_RX_HDR(pkt);
> struct iwl3945_rx_frame_end *rx_end = IWL_RX_END(pkt);
> short len = le16_to_cpu(rx_hdr->len);
>
We have an identical patch pending. I assumed most people compile with
led support and thus did not rush to get it in. Now that it is a problem
for more people I think this one should go in.
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Thank you
Reinette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211()
2009-08-12 15:37 ` reinette chatre
@ 2009-08-12 18:27 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2009-08-12 18:27 UTC (permalink / raw)
To: reinette chatre; +Cc: linville, linux-wireless
reinette chatre <reinette.chatre@intel.com> writes:
> On Wed, 2009-08-12 at 04:07 -0700, Kalle Valo wrote:
>> Commit "iwlwifi: Traffic type and counter for debugFs" broke iwl3945 in
>> a case when CONFIG_IWLWIFI_LEDS is disabled:
>>
>> drivers/net/wireless/iwlwifi/iwl-3945.c:580: error: 'hdr' undeclared (first use in this function)
>>
>> Fix it by removing the ifdef check for hdr variable.
[...]
> We have an identical patch pending. I assumed most people compile with
> led support and thus did not rush to get it in.
I don't remember why I have leds disabled. Most probably some problem a
long time ago and I never bothered to turn it back on.
> Now that it is a problem for more people I think this one should go
> in.
I agree that this should go in. Compilation errors are always annoying.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-12 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-12 11:07 [PATCH] iwl3945: fix compilation error in iwl3945_pass_packet_to_mac80211() Kalle Valo
2009-08-12 15:37 ` reinette chatre
2009-08-12 18:27 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).