linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: Igor Perminov <igor.perminov@inbox.ru>,
	Kalle Valo <kalle.valo@iki.fi>,
	linux-wireless@vger.kernel.org, hostap@lists.shmoo.com,
	Artur Skawina <art.08.09@gmail.com>
Subject: Re: A station can't reconnect after it wakes up
Date: Mon, 14 Sep 2009 10:42:44 -0700	[thread overview]
Message-ID: <1252950164.23427.50.camel@johannes.local> (raw)
In-Reply-To: <20090914125008.GA15494@jm.kir.nu>

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

On Mon, 2009-09-14 at 15:50 +0300, Jouni Malinen wrote:

> Taken into account that the AP can even change the Association ID for
> the STA during reassociation, I would be fine with dropping the buffered
> frames and clearing the PS state when association is completed
> successfully (the STA ACKs the (Re)Association Response frame that had
> status code 0). I would hope that the authentication frame sequence or
> failed (re)association would not touch the PS buffer or state.
> 
> The real time when the association state changes in the AP is when the
> ACK frame is received for (Re)Association Response frame. Of the options
> you listed, this would be bit after (B), i.e., (C) might be needed to
> get the exact timing right. However, I could probably live with (B),
> too, in practice.



> > But I think, we shouldn't call ap_sta_ps_end as is done for normal PS
> > state switching, because that leads to sending buffered frames if any,
> > which is undesirable in our case. Instead, we should simply purge of
> > buffered frames and clear WLAN_STA_PS.
> 
> This is a very good point and we much indeed make sure we do not end up
> sending the buffered frames out based on a new authentication or
> association frame. This is especially important for the case when the
> frames were buffered in RSNA,

Given all this, I still think it would be a lot simpler to just have
hostapd remove the station once.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-09-14 17:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1248969930.29068.224.camel@sunlight>
2009-07-31 16:16 ` A station can't reconnect after it wakes up Artur Skawina
2009-08-03 15:22   ` Igor Perminov
2009-09-10 22:03     ` Igor Perminov
2009-09-12 14:58       ` Johannes Berg
2009-09-12 23:51         ` Igor Perminov
2009-09-13  0:24           ` Christian Lamparter
2009-09-13 14:14           ` Kalle Valo
2009-09-14 11:24             ` Igor Perminov
2009-09-14 12:31               ` Holger Schurig
2009-09-14 22:55                 ` Igor Perminov
2009-09-14 12:50               ` Jouni Malinen
2009-09-14 17:42                 ` Johannes Berg [this message]
2009-07-28 15:38 Igor Perminov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252950164.23427.50.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=art.08.09@gmail.com \
    --cc=hostap@lists.shmoo.com \
    --cc=igor.perminov@inbox.ru \
    --cc=j@w1.fi \
    --cc=kalle.valo@iki.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).