From: Johannes Berg <johannes@sipsolutions.net>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iw: Add support for connection quality monitor configuation
Date: Thu, 25 Mar 2010 23:21:41 -0700 [thread overview]
Message-ID: <1269584501.4581.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1269584079.10120.889.camel@wimaxnb.nmp.nokia.com>
> > > + NLA_PUT_U32(cqm, NL80211_ATTR_CQM_RSSI_THOLD, thold);
> > > + NLA_PUT_U32(cqm, NL80211_ATTR_CQM_RSSI_HYST, hyst);
> >
> > Hmm. guess I missed that in the kernel side review, but should we change
> > the API so that leaving them out means disabling?
>
> Heh, yep, the kernel part does not disable this if these are left out.
>
> Actually, I can think of one downside to the approach you propose: when
> this gets extended, there will be multiple different cqm parameters, and
> they would have to be always configured simultaneously, otherwise some
> of the configurations would end up disabled. At least with iw, that
> would be somewhat awkward?
Hmm, yes, maybe. In that case you'd want leaving them out meaning no
change I guess. I'll give it another thought, but now I need to get
sleep and you won't hear from me again until I'm home on like Sunday :)
johannes
next prev parent reply other threads:[~2010-03-26 6:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 5:46 [PATCH] iw: Add support for connection quality monitor configuation Juuso Oikarinen
2010-03-26 6:07 ` Johannes Berg
2010-03-26 6:14 ` Juuso Oikarinen
2010-03-26 6:21 ` Johannes Berg [this message]
2010-03-26 6:23 ` Juuso Oikarinen
2010-03-31 4:53 ` Juuso Oikarinen
2010-03-31 5:23 ` Johannes Berg
2010-03-31 5:24 ` Juuso Oikarinen
2010-03-31 5:36 ` Johannes Berg
2010-03-31 5:45 ` Juuso Oikarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269584501.4581.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).