From: Dan Williams <dcbw@redhat.com> To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, Steve deRosier <steve@cozybit.com>, Alagu Sankar <alagusankar@gmail.com> Subject: [PATCH] libertas: fix 8686 firmware loading regression in 96021f096e5178582af296a2fbb6df7dbd6b695c Date: Wed, 28 Apr 2010 12:37:46 -0700 [thread overview] Message-ID: <1272483466.14103.4.camel@localhost.localdomain> (raw) In-Reply-To: <1272413690.32717.10.camel@localhost.localdomain> The 'ready' condition was incorrectly evaluated which sometimes lead to failures loading the second-stage firmware on 8686 devices. Signed-off-by: Dan Williams <dcbw@redhat.com> --- diff --git a/drivers/net/wireless/libertas/if_sdio.c b/drivers/net/wireless/libertas/if_sdio.c index 13dfeda..64dd345 100644 --- a/drivers/net/wireless/libertas/if_sdio.c +++ b/drivers/net/wireless/libertas/if_sdio.c @@ -324,7 +324,9 @@ static int if_sdio_wait_status(struct if_sdio_card *card, const u8 condition) timeout = jiffies + HZ; while (1) { status = sdio_readb(card->func, IF_SDIO_STATUS, &ret); - if (ret || (status & condition)) + if (ret) + return ret; + if ((status & condition) == condition) break; if (time_after(jiffies, timeout)) return -ETIMEDOUT;
next prev parent reply other threads:[~2010-04-28 19:37 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-27 19:35 libertas sdio broken on XO-1.5s Steve deRosier 2010-04-28 0:14 ` Dan Williams 2010-04-28 19:37 ` Dan Williams [this message] 2010-04-28 23:33 ` [PATCH] libertas: fix 8686 firmware loading regression in 96021f096e5178582af296a2fbb6df7dbd6b695c Steve deRosier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1272483466.14103.4.camel@localhost.localdomain \ --to=dcbw@redhat.com \ --cc=alagusankar@gmail.com \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=steve@cozybit.com \ --subject='Re: [PATCH] libertas: fix 8686 firmware loading regression in 96021f096e5178582af296a2fbb6df7dbd6b695c' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).