linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: stable@kernel.org, greg@kroah.com
Cc: linux-wireless@vger.kernel.org,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>,
	Peter Stuge <peter@stuge.se>,
	"Justin P. Mattock" <justinmattock@gmail.com>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH 2.6.32.y] ath9k: re-enable ps by default for new single chip families
Date: Tue, 15 Jun 2010 18:19:19 -0400	[thread overview]
Message-ID: <1276640359-25360-1-git-send-email-lrodriguez@atheros.com> (raw)

commit 14acdde6e527950f66c084dbf19bad6fbfcaeedc upstream.

The newer single chip hardware family of chipsets have not been
experiencing issues with power saving set by default with recent
fixes merged (even into stable). The remaining issues are only
reported with AR5416 and since enabling PS by default can increase
power savings considerably best to take advantage of that feature
as this has been tested properly.

For more details on this issue see the bug report:

http://bugzilla.kernel.org/show_bug.cgi?id=14267

We leave AR5416 with PS disabled by default, that seems to require
some more work.

Cc: stable@kernel.org
Cc: Peter Stuge <peter@stuge.se>
Cc: Justin P. Mattock  <justinmattock@gmail.com>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---

Greg, this is the long promised backport of the patch titled
"ath9k: re-enable ps by default for new single chip families" backported
down to 2.6.32.y. This just goes test compiled. Manual backport
was required from the upstream Linus patch since the flag
WIPHY_FLAG_PS_ON_BY_DEFAULT was not used back on 2.6.32 so instead
we use the equivalent hw->wiphy->ps_default bool.

Apologies for the delay, was just stuck with other stuff.

I'll remove this from the stable pending list for 802.11 [1] once
this gets sucked in.

[1] http://wireless.kernel.org/en/developers/stable-pending

 drivers/net/wireless/ath/ath9k/main.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 15eb245..dba27b7 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1538,6 +1538,8 @@ bad_no_ah:
 
 void ath_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
 {
+	struct ath_hw *ah = sc->sc_ah;
+
 	hw->flags = IEEE80211_HW_RX_INCLUDES_FCS |
 		IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING |
 		IEEE80211_HW_SIGNAL_DBM |
@@ -1556,7 +1558,10 @@ void ath_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
 		BIT(NL80211_IFTYPE_ADHOC) |
 		BIT(NL80211_IFTYPE_MESH_POINT);
 
-	hw->wiphy->ps_default = false;
+	if (AR_SREV_5416(ah))
+		hw->wiphy->ps_default = false;
+	else
+		hw->wiphy->ps_default = true;
 
 	hw->queues = 4;
 	hw->max_rates = 4;
-- 
1.6.3.3


             reply	other threads:[~2010-06-15 22:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 22:19 Luis R. Rodriguez [this message]
2010-06-16  2:20 ` [PATCH 2.6.32.y] ath9k: re-enable ps by default for new single chip families Justin P. Mattock
2010-06-16  8:12 ` Kristoffer Ericson
2010-06-16 13:33   ` Justin P. Mattock
2010-06-16 15:49     ` Luis R. Rodriguez
2010-06-16 16:01       ` Justin P. Mattock
2010-06-16 17:53         ` Luis R. Rodriguez
2010-06-16 18:15           ` Justin P. Mattock
2010-06-16 18:16             ` Luis R. Rodriguez
2010-06-16 19:14               ` Justin P. Mattock
2010-06-16 20:06                 ` Luis R. Rodriguez
2010-06-16 20:40                   ` Justin P. Mattock
2010-06-16 15:48   ` Luis R. Rodriguez
2010-07-27 22:22 ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276640359-25360-1-git-send-email-lrodriguez@atheros.com \
    --to=lrodriguez@atheros.com \
    --cc=greg@kroah.com \
    --cc=justinmattock@gmail.com \
    --cc=kristoffer.ericson@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=peter@stuge.se \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).