archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <>
To: "John W. Linville" <>
Subject: Re: [PATCH 1/2] mac80211: support use of NAPI for bottom-half processing
Date: Thu, 29 Jul 2010 22:39:38 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 2010-07-29 at 16:14 -0400, John W. Linville wrote:

> +	struct napi_struct napi;
> +	int napi_weight;

Why is the napi struct visible to drivers? Ok .. I see later.

> @@ -1679,6 +1684,8 @@ enum ieee80211_ampdu_mlme_action {
>   *	switch operation for CSAs received from the AP may implement this
>   *	callback. They must then call ieee80211_chswitch_done() to indicate
>   *	completion of the channel switch.
> + *
> + * @napi_poll: Poll Rx queue for incoming data frames.

should this document that napi_weight must be set?

> +	int (*napi_poll)(struct napi_struct *napi, int budget);

I'd prefer passing the hw here and having mac80211 wrap it in a simple
function that does the container_of magic? Anything preventing that?
Then the napi struct can be hidden from drivers.


  parent reply	other threads:[~2010-07-29 20:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 20:14 [PATCH 1/2] mac80211: support use of NAPI for bottom-half processing John W. Linville
2010-07-29 20:14 ` [PATCH 2/2] rtl8180: use " John W. Linville
2010-07-29 20:39 ` Johannes Berg [this message]
2010-07-29 20:42   ` [PATCH 1/2] mac80211: support use of " Johannes Berg
2010-07-29 21:14   ` [PATCH v2 " John W. Linville
2010-07-29 21:14   ` [PATCH v2 2/2] rtl8180: use " John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).