From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:36136 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754421Ab0HCK5S (ORCPT ); Tue, 3 Aug 2010 06:57:18 -0400 Subject: Re: [PATCH v2] wireless: ipw2100: check result of kzalloc() From: Christoph Fritz To: Dan Carpenter Cc: "John W. Linville" , kernel-janitors , "David S. Miller" , Reinette Chatre , linux-wireless In-Reply-To: <1280831322.3034.7.camel@lovely.krouter> References: <1280797822.11158.55.camel@lovely.krouter> <20100803081701.GP26313@bicker> <1280831322.3034.7.camel@lovely.krouter> Content-Type: text/plain; charset="ISO-8859-1" Date: Tue, 03 Aug 2010 12:54:20 +0200 Message-ID: <1280832860.3034.35.camel@lovely.krouter> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: If kzalloc() fails return with -ENOMEM from ipw2100_net_init() which is called by register_netdev. CC: Dan Carpenter Signed-off-by: Christoph Fritz --- drivers/net/wireless/ipw2x00/ipw2100.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c index 0bd4dfa..cbec02a 100644 --- a/drivers/net/wireless/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/ipw2x00/ipw2100.c @@ -1924,6 +1924,10 @@ static int ipw2100_net_init(struct net_device *dev) bg_band->channels = kzalloc(geo->bg_channels * sizeof(struct ieee80211_channel), GFP_KERNEL); + if (!bg_band->channels) { + ipw2100_down(priv); + return -ENOMEM; + } /* translate geo->bg to bg_band.channels */ for (i = 0; i < geo->bg_channels; i++) { bg_band->channels[i].band = IEEE80211_BAND_2GHZ; -- 1.7.1