From: Johannes Berg <johannes@sipsolutions.net>
To: Alex Romosan <romosan@sycorax.lbl.gov>
Cc: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: iwlwifi connection problems
Date: Wed, 04 Aug 2010 09:52:45 +0200 [thread overview]
Message-ID: <1280908365.3768.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <87mxt3n9xh.fsf@sycorax.lbl.gov>
On Tue, 2010-08-03 at 05:43 -0700, Alex Romosan wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > Yes, thank you, but it's very strange. But it's probably ok, let's
> > remove the call then, it wasn't there before. Want to post a patch
> > yourself?
>
> btw, the old code had this comment
>
> /* We avoid iwl_commit_rxon here to commit the new filter flags
> * since mac80211 will call ieee80211_hw_config immediately.
> * (mc_list is not supported at this time). Otherwise, we need to
> * queue a background iwl_commit_rxon work.
> */
Yes, but that predates this callback being able to sleep, which
according to the comment is the reason for not committing here. Now that
the callback could sleep, I figured we could safely commit there, I have
no idea why that caused issues with your AP.
I realised though that mac80211 will sometimes call the filter config
w/o calling hw_config() immediately, so I'd prefer actually figuring out
what the issue with your AP is. Could you rebuild your kernel with
CONFIG_MAC80211_DRIVER_API_TRACER and CONFIG_IWLWIFI_DEVICE_TRACING, get
trace-cmd from
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git and
record traces for me? I'd like to have
trace-cmd record -e iwlwifi -e mac80211
for both the working and non-working case, preferably the same kernel
with that single line of code changed. Please compress the output.
johannes
next prev parent reply other threads:[~2010-08-04 7:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 20:14 iwlwifi connection problems Alex Romosan
2010-07-23 20:38 ` Guy, Wey-Yi
2010-07-26 9:17 ` Johannes Berg
2010-07-27 4:59 ` Alex Romosan
2010-07-27 6:37 ` Johannes Berg
2010-08-02 0:18 ` Alex Romosan
2010-08-02 10:58 ` Johannes Berg
2010-08-02 15:42 ` Alex Romosan
2010-08-02 16:23 ` Johannes Berg
2010-08-03 3:53 ` Alex Romosan
2010-08-03 6:39 ` Johannes Berg
2010-08-03 12:32 ` Alex Romosan
2010-08-03 12:43 ` Alex Romosan
2010-08-04 7:52 ` Johannes Berg [this message]
2010-08-04 14:51 ` Alex Romosan
2010-08-04 15:03 ` Johannes Berg
2010-08-04 15:08 ` Alex Romosan
2010-08-04 15:11 ` Johannes Berg
2010-08-04 15:12 ` Alex Romosan
2010-08-04 15:23 ` Johannes Berg
2010-08-16 13:16 ` Johannes Berg
2010-08-16 13:44 ` Alex Romosan
2010-08-16 16:40 ` Alex Romosan
2010-08-16 19:06 ` Johannes Berg
2010-08-17 9:24 ` [PATCH] iwlwifi: fix 3945 filter flags Johannes Berg
2010-08-19 16:01 ` Alex Romosan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280908365.3768.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=romosan@sycorax.lbl.gov \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).