archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <>
To: Christian Lamparter <>
	"John W. Linville" <>
Subject: Re: [PATCH 3/3 v2] mac80211: AMPDU rx reorder timeout timer
Date: Thu, 05 Aug 2010 11:04:37 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 2010-08-05 at 01:36 +0200, Christian Lamparter wrote:
> This patch introduces a new timer, which will release
> queued-up MPDUs from the reorder buffer, whenever
> they've waited for more than HT_RX_REORDER_BUF_TIMEOUT
> (which is at around 100 ms).
> The advantage of having a dedicated timer, instead of
> relying on a constant stream of freshly arriving aMPDUs
> to release the old ones, is particularly observable when
> even a small fraction of MPDUs are forever lost at
> low network speeds.
> Previously under these circumstances frames would become
> stuck in the reorder buffer and the network stack of both
> HT peers throttled back, instead of revving up and
> gunning the pipes.
> Signed-off-by: Christian Lamparter <>
> ---
> WIP -> v1:
>  	- thread-safe ampdu reordering
>  	- do the reorder release in the timer
> v1 -> v2:
> 	- update documentation entries
> 	- refine locking
> NB:
> I hope the timed release stuff is now probably protected against
> races from the RX - path. The code was tested and nothing blew up,
> that said the testbed only had a puny single-core Pentium M engine...
> But nevertheless, it managed to hold tcp speed high enough to
> qualify as an 11n device (~ 60mbps) over the bad link.

This set looks fine to me. I may do some cleanup afterwards wrt. the rx
struct :-)


      reply	other threads:[~2010-08-05  9:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04 23:36 [PATCH 3/3 v2] mac80211: AMPDU rx reorder timeout timer Christian Lamparter
2010-08-05  9:04 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).